Skip to content

HDDS-4533.Avoid rewriting pipeline information during PipelineStateManagerV2Impl initialization #1796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
runzhiwang merged 1 commit into from
Jan 15, 2021
Merged

HDDS-4533.Avoid rewriting pipeline information during PipelineStateManagerV2Impl initialization #1796

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...ver-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineStateManagerV2Impl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,8 @@ private void initialize() throws IOException {
iterator = pipelineStore.iterator();
while (iterator.hasNext()) {
Pipeline pipeline = iterator.next().getValue();
addPipeline(pipeline.getProtobufMessage());
Copy link
Contributor Author

@amaliujia amaliujia Jan 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addPipeline will do the following:

      Pipeline pipeline = Pipeline.getFromProtobuf(pipelineProto);
      pipelineStore.put(pipeline.getId(), pipeline);
      pipelineStateMap.addPipeline(pipeline);
      nodeManager.addPipeline(pipeline);

pipelineStore.put(pipeline.getId(), pipeline); should be avoided.

pipelineStateMap.addPipeline(pipeline);
nodeManager.addPipeline(pipeline);
}
}

Expand Down