HDDS-4533.Avoid rewriting pipeline information during PipelineStateManagerV2Impl initialization #1796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nagerV2Impl initialization
amaliujia
commented
Jan 14, 2021
| iterator = pipelineStore.iterator(); | ||
| while (iterator.hasNext()) { | ||
| Pipeline pipeline = iterator.next().getValue(); | ||
| addPipeline(pipeline.getProtobufMessage()); |
Contributor
Author
There was a problem hiding this comment.
addPipeline will do the following:
Pipeline pipeline = Pipeline.getFromProtobuf(pipelineProto);
pipelineStore.put(pipeline.getId(), pipeline);
pipelineStateMap.addPipeline(pipeline);
nodeManager.addPipeline(pipeline);
pipelineStore.put(pipeline.getId(), pipeline); should be avoided.
Contributor
Author
|
R: @runzhiwang @GlenGeng @ChenSammi @bshashikant |
Contributor
|
+1 |
Contributor
Author
|
@GlenGeng @runzhiwang thanks! CI all green now |
Contributor
|
@amaliujia Thanks the patch. @GlenGeng Thanks for review. I have merged the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
During initialization, PipelineStateManagerV2Impl will rewrites pipeline info into the store. We should avoid it.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4533
How was this patch tested?
UT