Skip to content

HDDS-2462. Add jq dependency in Contribution guideline #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anuengineer merged 2 commits into from
Nov 12, 2019
Merged

HDDS-2462. Add jq dependency in Contribution guideline #145

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdd2436
HDDS-2462. Add jq dependency in Contribution guideline
fapifta Nov 12, 2019
85bb724
Address review suggestion from @adoroszlai
fapifta Nov 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTION.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ Additional requirements to execute different type of tests:
* [Robot framework](https://robotframework.org/) (for executing acceptance tests)
* docker-compose (to start pseudo cluster, also used for blockade and acceptance tests)
* [blockade](https://pypi.org/project/blockade/) To execute network fault-injection testing.
* [jq](https://stedolan.github.io/jq/) To parse JMX results from different processes running in containers in docker based tests.
Copy link
Contributor

@adoroszlai adoroszlai Nov 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be easier to understand for newcomers if it simply said "for executing acceptance tests" (same as for Robot framework).

Copy link
Contributor Author

@fapifta fapifta Nov 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea, and actually it is really just as simple as with robot framework. I have commited the suggestion to the PR branch.

Copy link
Contributor

@adoroszlai adoroszlai Nov 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


Optional dependencies:

Expand Down