HDDS-2462. Add jq dependency in Contribution guideline #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
reviewed
Nov 12, 2019
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @fapifta for spotting this dependency.
CONTRIBUTION.md
Outdated
| * [Robot framework](https://robotframework.org/) (for executing acceptance tests) | ||
| * docker-compose (to start pseudo cluster, also used for blockade and acceptance tests) | ||
| * [blockade](https://pypi.org/project/blockade/) To execute network fault-injection testing. | ||
| * [jq](https://stedolan.github.io/jq/) To parse JMX results from different processes running in containers in docker based tests. |
Contributor
There was a problem hiding this comment.
I think it would be easier to understand for newcomers if it simply said "for executing acceptance tests" (same as for Robot framework).
Contributor
Author
There was a problem hiding this comment.
I like the idea, and actually it is really just as simple as with robot framework. I have commited the suggestion to the PR branch.
elek
approved these changes
Nov 12, 2019
Member
elek
left a comment
elek
left a comment
There was a problem hiding this comment.
+1 Thanks the update of the document.
Contributor
|
Committed to the trunk .. Thanks for the reviews, @elek, @adoroszlai . Thanks for the contribution @fapifta |
ptlrs
pushed a commit
to ptlrs/ozone
that referenced
this pull request
Mar 8, 2025
apache#7250) (apache#145) (cherry picked from commit c91f1c7) Co-authored-by: Sumit Agrawal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Documentation update, add jq dependency into the Contribution Guideline in the "Additional requirements to execute different type of tests" section
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2462
How was this patch tested?
Doc change, no tests needed as far as I can tell.