Skip to content

HDDS-4198. Compile Ozone with multiple Java versions #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elek merged 3 commits into from
Sep 7, 2020
Merged

HDDS-4198. Compile Ozone with multiple Java versions #1387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
effc850
HDDS-4197. Failed to load existing service definition files: ...Subco…
adoroszlai Sep 2, 2020
25d9924
HDDS-4198. Compile Ozone with multiple Java versions
adoroszlai Sep 2, 2020
d959cf4
Display version information in Maven
adoroszlai Sep 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions .github/workflows/post-commit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ jobs:
build:
name: compile
runs-on: ubuntu-18.04
strategy:
matrix:
java: [ 8, 11 ]
fail-fast: false
steps:
- name: Checkout project
uses: actions/checkout@v2
Expand All @@ -34,10 +38,17 @@ jobs:
key: ${{ runner.os }}-pnpm-${{ hashFiles('**/pnpm-lock.yaml') }}
restore-keys: |
${{ runner.os }}-pnpm-
- name: Execute tests
uses: ./.github/buildenv
- name: Cache for maven dependencies
uses: actions/cache@v2
with:
args: ./hadoop-ozone/dev-support/checks/build.sh
Copy link
Member

@elek elek Sep 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can consider doing the same with all the other steps.

path: ~/.m2/repository
key: maven-repo-${{ hashFiles('**/pom.xml') }}
- name: Setup java
uses: actions/setup-java@v1
with:
java-version: ${{ matrix.java }}
- name: Run a full build
run: hadoop-ozone/dev-support/checks/build.sh
bats:
runs-on: ubuntu-18.04
steps:
Expand Down
2 changes: 1 addition & 1 deletion hadoop-ozone/dev-support/checks/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,5 @@ DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
cd "$DIR/../../.." || exit 1

export MAVEN_OPTS="-Xmx4096m"
mvn -B -Dmaven.javadoc.skip=true -DskipTests clean install "$@"
mvn -V -B -Dmaven.javadoc.skip=true -DskipTests clean install "$@"
Copy link
Member

@elek elek Sep 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-V --> very nice, never used this flag #TIL

exit $?
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1335,7 +1335,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs
<dependency>
<groupId>org.kohsuke.metainf-services</groupId>
<artifactId>metainf-services</artifactId>
<version>1.1</version>
<version>1.8</version>
<optional>true</optional>
</dependency>
<dependency>
Expand Down