HDDS-4198. Compile Ozone with multiple Java versions #1387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elek
approved these changes
Sep 7, 2020
Member
elek
left a comment
elek
left a comment
There was a problem hiding this comment.
+1, thanks the patch @adoroszlai
Good to be sure that Ozone can be compiled with JDK 11.
|
|
||
| export MAVEN_OPTS="-Xmx4096m" | ||
| mvn -B -Dmaven.javadoc.skip=true -DskipTests clean install "$@" | ||
| mvn -V -B -Dmaven.javadoc.skip=true -DskipTests clean install "$@" |
Member
There was a problem hiding this comment.
-V --> very nice, never used this flag #TIL
| - name: Cache for maven dependencies | ||
| uses: actions/cache@v2 | ||
| with: | ||
| args: ./hadoop-ozone/dev-support/checks/build.sh |
Member
There was a problem hiding this comment.
We can consider doing the same with all the other steps.
Contributor
Author
|
Thanks @vivekratnavel for the review, and @elek for reviewing and committing it. |
llemec
pushed a commit
to llemec/hadoop-ozone
that referenced
this pull request
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Compile Ozone with both Java 8 and 11 in CI.
Note: this is based on top of #1386.
https://issues.apache.org/jira/browse/HDDS-4198
How was this patch tested?
https://github.com/adoroszlai/hadoop-ozone/runs/1063860191#step:6:10
https://github.com/adoroszlai/hadoop-ozone/runs/1063860210#step:6:10