HDDS-3979. Make bufferSize configurable for stream copy #1212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runzhiwang
reviewed
Jul 22, 2020
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/KeyInputStream.java
Outdated
Show resolved
Hide resolved
maobaolong
changed the title
runzhiwang
reviewed
Jul 22, 2020
...ne/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestKeyInputStream.java
Outdated
Show resolved
Hide resolved
runzhiwang
reviewed
Jul 22, 2020
...ne/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestKeyInputStream.java
Outdated
Show resolved
Hide resolved
Member
Author
|
@runzhiwang Thanks for the review, addressed all of your suggestion, PTAL. |
runzhiwang
reviewed
Jul 22, 2020
Member
Author
|
@runzhiwang Thank you for your review and |
elek
requested changes
Jul 29, 2020
Member
elek
left a comment
elek
left a comment
There was a problem hiding this comment.
Thanks the patch @maobaolong (and the review @runzhiwang).
It LGTM. Based on my understanding we switch to use a normal seek + IOUtils instead of the custom method. (:+1:)
I added a few comments (inline). The only blocker is to add s3g to the config (but I might miss something...)
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConfigKeys.java
Show resolved
Hide resolved
| } | ||
|
|
||
| @PostConstruct | ||
| public void init() { |
Member
There was a problem hiding this comment.
NIT: It can be slightly better to use
@Inject
private OzoneConfiguration ozoneConfiguration;
And you don't need to expose getClient() in the EndpointBase.
(Didn't try, but it should work, IMHO).
Member
Author
There was a problem hiding this comment.
Thank you for let me know this high technology
Member
Author
|
@elek Thanks you for your review and suggestion, i've addressed your comments, PTAL. |
… s3g prefix to the config key.
elek
approved these changes
Aug 11, 2020
Member
elek
left a comment
elek
left a comment
There was a problem hiding this comment.
+1, thanks the update @maobaolong
errose28
added a commit
to errose28/ozone
that referenced
this pull request
Aug 12, 2020
* master: (28 commits) HDDS-4037. Incorrect container numberOfKeys and usedBytes in SCM after key deletion (apache#1295) HDDS-3232. Include the byteman scripts in the distribution tar file (apache#1309) HDDS-4095. Byteman script to debug HCFS performance (apache#1311) HDDS-4057. Failed acceptance test missing from bundle (apache#1283) HDDS-4040. [OFS] BasicRootedOzoneFileSystem to support batchDelete (apache#1286) HDDS-4061. Pending delete blocks are not always included in #BLOCKCOUNT metadata (apache#1288) HDDS-4067. Implement toString for OMTransactionInfo (apache#1300) HDDS-3878. Make OMHA serviceID optional if one (but only one) is defined in the config (apache#1149) HDDS-3833. Use Pipeline choose policy to choose pipeline from exist pipeline list (apache#1096) HDDS-3979. Make bufferSize configurable for stream copy (apache#1212) HDDS-4048. Show more information while SCM version info mismatch (apache#1278) HDDS-4078. Use HDDS InterfaceAudience/Stability annotations (apache#1302) HDDS-4034. Add Unit Test for HadoopNestedDirGenerator. (apache#1266) HDDS-4076. Translate CSI.md into Chinese (apache#1299) HDDS-4046. Extensible subcommands for CLI applications (apache#1276) HDDS-4051. Remove whitelist/blacklist terminology from Ozone (apache#1306) HDDS-4055. Cleanup GitHub workflow (apache#1282) HDDS-4042. Update documentation for the GA release (apache#1269) HDDS-4066. Add core-site.xml to intellij configuration (apache#1292) HDDS-4073. Remove leftover robot.robot (apache#1297) ...
rakeshadr
pushed a commit
to rakeshadr/hadoop-ozone
that referenced
this pull request
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
IOUtils#copyLargeto clarify and reduce the duplicated code.IOUtils#copyLarge.What is the link to the Apache JIRA
HDDS-3979
How was this patch tested?
Using awscli or goofys