HDDS-3951. Rename the num.write.chunk.thread key. #1187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@maobaolong, suggest change from " per disk" to " per volume" to be consistent with other datanode property naming style. |
Member
Author
|
@ChenSammi Thanks for your suggestion，I have addressed your comment，PTAL |
Contributor
|
LGTM, +1. Thanks @maobaolong for the contribution and all for the reviews. |
xiaoyuyao
pushed a commit
that referenced
this pull request
Jul 13, 2020
Member
Author
|
@ChenSammi @xiaoyuyao Thank you for your review. |
rakeshadr
pushed a commit
to rakeshadr/hadoop-ozone
that referenced
this pull request
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Reanme
dfs.container.ratis.num.write.chunk.threadtodfs.container.ratis.num.write.chunk.thread.per.diskto clearly express the meaning of this key, if it configured to 10, then the thread num would be 10 * numOfDisk.
What is the link to the Apache JIRA
HDDS-3951
How was this patch tested?
NO Need, just rename config key.