Skip to content

Commit e89e4cf

Browse files
maobaolongxiaoyuyao
authored andcommitted
HDDS-3951. Rename the num.write.chunk.thread key. (#1187)
(cherry picked from commit 92926ae)
1 parent a15c68c commit e89e4cf

File tree

6 files changed

+20
-12
lines changed

6 files changed

+20
-12
lines changed

hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ScmConfigKeys.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,11 @@ public final class ScmConfigKeys {
4444
= "dfs.container.ratis.rpc.type";
4545
public static final String DFS_CONTAINER_RATIS_RPC_TYPE_DEFAULT
4646
= "GRPC";
47-
public static final String DFS_CONTAINER_RATIS_NUM_WRITE_CHUNK_THREADS_KEY
48-
= "dfs.container.ratis.num.write.chunk.threads";
49-
public static final int DFS_CONTAINER_RATIS_NUM_WRITE_CHUNK_THREADS_DEFAULT
47+
public static final String
48+
DFS_CONTAINER_RATIS_NUM_WRITE_CHUNK_THREADS_PER_VOLUME
49+
= "dfs.container.ratis.num.write.chunk.threads.per.volume";
50+
public static final int
51+
DFS_CONTAINER_RATIS_NUM_WRITE_CHUNK_THREADS_PER_VOLUME_DEFAULT
5052
= 10;
5153
public static final String DFS_CONTAINER_RATIS_REPLICATION_LEVEL_KEY
5254
= "dfs.container.ratis.replication.level";

hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConfigKeys.java

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -248,10 +248,13 @@ public final class OzoneConfigKeys {
248248
= ScmConfigKeys.DFS_CONTAINER_RATIS_RPC_TYPE_KEY;
249249
public static final String DFS_CONTAINER_RATIS_RPC_TYPE_DEFAULT
250250
= ScmConfigKeys.DFS_CONTAINER_RATIS_RPC_TYPE_DEFAULT;
251-
public static final String DFS_CONTAINER_RATIS_NUM_WRITE_CHUNK_THREADS_KEY
252-
= ScmConfigKeys.DFS_CONTAINER_RATIS_NUM_WRITE_CHUNK_THREADS_KEY;
253-
public static final int DFS_CONTAINER_RATIS_NUM_WRITE_CHUNK_THREADS_DEFAULT
254-
= ScmConfigKeys.DFS_CONTAINER_RATIS_NUM_WRITE_CHUNK_THREADS_DEFAULT;
251+
public static final String
252+
DFS_CONTAINER_RATIS_NUM_WRITE_CHUNK_THREADS_PER_VOLUME_KEY
253+
= ScmConfigKeys.DFS_CONTAINER_RATIS_NUM_WRITE_CHUNK_THREADS_PER_VOLUME;
254+
public static final int
255+
DFS_CONTAINER_RATIS_NUM_WRITE_CHUNK_THREADS_PER_VOLUME_DEFAULT
256+
= ScmConfigKeys.
257+
DFS_CONTAINER_RATIS_NUM_WRITE_CHUNK_THREADS_PER_VOLUME_DEFAULT;
255258
public static final String DFS_CONTAINER_RATIS_REPLICATION_LEVEL_KEY
256259
= ScmConfigKeys.DFS_CONTAINER_RATIS_REPLICATION_LEVEL_KEY;
257260
public static final ReplicationLevel

hadoop-hdds/common/src/main/resources/ozone-default.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@
196196
</description>
197197
</property>
198198
<property>
199-
<name>dfs.container.ratis.num.write.chunk.threads</name>
199+
<name>dfs.container.ratis.num.write.chunk.threads.per.volume</name>
200200
<value>10</value>
201201
<tag>OZONE, RATIS, PERFORMANCE</tag>
202202
<description>Maximum number of threads in the thread pool that Datanode

hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/XceiverServerRatis.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -782,8 +782,10 @@ private static List<ThreadPoolExecutor> createChunkExecutors(
782782
ConfigurationSource conf) {
783783
// TODO create single pool with N threads if using non-incremental chunks
784784
final int threadCountPerDisk = conf.getInt(
785-
OzoneConfigKeys.DFS_CONTAINER_RATIS_NUM_WRITE_CHUNK_THREADS_KEY,
786-
OzoneConfigKeys.DFS_CONTAINER_RATIS_NUM_WRITE_CHUNK_THREADS_DEFAULT);
785+
OzoneConfigKeys
786+
.DFS_CONTAINER_RATIS_NUM_WRITE_CHUNK_THREADS_PER_VOLUME_KEY,
787+
OzoneConfigKeys
788+
.DFS_CONTAINER_RATIS_NUM_WRITE_CHUNK_THREADS_PER_VOLUME_DEFAULT);
787789

788790
final int numberOfDisks =
789791
MutableVolumeSet.getDatanodeStorageDirs(conf).size();

hadoop-ozone/fault-injection-test/mini-chaos-tests/src/test/java/org/apache/hadoop/ozone/MiniOzoneChaosCluster.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,8 @@ protected void initializeConfiguration() throws IOException {
225225
conf.setTimeDuration(HddsConfigKeys.HDDS_HEARTBEAT_INTERVAL, 1,
226226
TimeUnit.SECONDS);
227227
conf.setInt(
228-
OzoneConfigKeys.DFS_CONTAINER_RATIS_NUM_WRITE_CHUNK_THREADS_KEY,
228+
OzoneConfigKeys
229+
.DFS_CONTAINER_RATIS_NUM_WRITE_CHUNK_THREADS_PER_VOLUME_KEY,
229230
4);
230231
conf.setInt(
231232
OzoneConfigKeys.DFS_CONTAINER_RATIS_NUM_CONTAINER_OP_EXECUTORS_KEY,

hadoop-ozone/integration-test/src/test/resources/ozone-site.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
</property>
2828

2929
<property>
30-
<name>dfs.container.ratis.num.write.chunk.threads</name>
30+
<name>dfs.container.ratis.num.write.chunk.threads.per.volume</name>
3131
<value>4</value>
3232
</property>
3333

0 commit comments

Comments
 (0)