Skip to content

Conversation

@elek
Copy link
Member

@elek elek commented Jun 19, 2020

What changes were proposed in this pull request?

Using legacy jar is legacy. We need to updated all the docs.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-3704

How was this patch tested?

I followed the instructions from docs/content/recipe/SparkOzoneFSK8S.md to test if it still works.

Also tested with

cd hadoop-hdds/docs/content
grep -r lib-legacy
grep -r lib-current

Copy link
Contributor

@xiaoyuyao xiaoyuyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just few minor comments inline

@elek
Copy link
Member Author

elek commented Jun 22, 2020

Thanks the review @xiaoyuyao. I pushed the commit, but please check it as I am not sure about one character which is visible as � for me:

image

BTW, it's an interesting question how can we maintain the doc with two languages. Do you know any good tool which can manage the translations (even if external). Something which can flag the modified parts / new paragraph to request and update on the documentation. (cc: @iamabug ).

@xiaoyuyao
Copy link
Contributor

bq. Do you know any good tool which can manage the translations (even if external).

Not as far as I know. How about we generate a md5 of each english document and its corresponding documents in other languages. Then add a unit test that fail if check if the md5 of english document matches. If not, assert that md5 of doc for other languages must be updated.

@iamabug
Copy link
Contributor

iamabug commented Jun 24, 2020

How about we align two translations at some version, and afterwards set a trigger on commits that relate to English docs, the trigger creates tickets which point to the said commits under a long-term ticket. Then we can check and resolve these tickets. Just an idea, not sure if possible.

@elek
Copy link
Member Author

elek commented Jun 25, 2020

Thanks the idea. Both sounds good. As a first step I started to use translation-required-zh jira label for resolved issues which modified the English translation (one issue on the list)

And thanks the review. As the last issue is fixed (? Character is removed) and all problems are addressed, I am merging it to the master.

@elek elek merged commit fe015bd into apache:master Jun 25, 2020
errose28 added a commit to errose28/ozone that referenced this pull request Jun 25, 2020
* upstream/master: (56 commits)
  HDDS-3264. Fix TestCSMMetrics.java. (apache#1120)
  HDDS-3858. Remove support to start Ozone and HDFS datanodes in the same JVM (apache#1117)
  HDDS-3704. Update all the documentation to use ozonefs-hadoop2/3 instead of legacy/current (apache#1099)
  HDDS-3773. Add OMDBDefinition to define structure of om.db. (apache#1076)
  Revert "HDDS-3263. Fix TestCloseContainerByPipeline.java. (apache#1119)" (apache#1126)
  HDDS-3821. Disable Ozone SPNEGO should not fall back to hadoop.http.a… (apache#1101)
  HDDS-3819. OzoneManager#listVolumeByUser ignores userName parameter when ACL is enabled (apache#1087)
  HDDS-3779. Add csi interface documents to show how to use ozone csi (apache#1059)
  HDDS-3857. Datanode in compose/ozonescripts can't be started (apache#1116)
  HDDS-3430. Enable TestWatchForCommit test cases. (apache#1114)
  HDDS-3263. Fix TestCloseContainerByPipeline.java. (apache#1119)
  HDDS-3512. s3g multi-part-upload saved incorrect content using streaming (apache#1092)
  HDDS-3836. Modify ContainerPlacementPolicyFactory JavaDoc (apache#1097)
  HDDS-3780. Replace the imagePullPolicy from always to IfNotPresent (apache#1055)
  HDDS-3847. Change OMNotLeaderException logging to DEBUG (apache#1118)
  HDDS-3745. Improve OM and SCM performance with 64% by avoid collect datanode information to s3g (apache#1031)
  HDDS-3286. BasicOzoneFileSystem  support batchDelete. (apache#814)
  HDDS-3850. Update the admin document to let user know how to show the status of all rules. (apache#1109)
  HDDS-3848. Add ratis.thirdparty.version in main pom.xml (apache#1108)
  HDDS-3815. Avoid buffer copy in ContainerCommandRequestProto. (apache#1085)
  ...
@elek
Copy link
Member Author

elek commented Jun 26, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants