Skip to content

Conversation

@maobaolong
Copy link
Member

What changes were proposed in this pull request?

Add csi interface documents to show how to use ozone csi

What is the link to the Apache JIRA

https://jira.apache.org/jira/browse/HDDS-3779

How was this patch tested?

No need, only docs changed.

@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2020

Codecov Report

Merging #1059 into master will increase coverage by 1.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1059      +/-   ##
============================================
+ Coverage     69.48%   70.49%   +1.00%     
- Complexity     9110     9249     +139     
============================================
  Files           961      961              
  Lines         48132    48130       -2     
  Branches       4672     4676       +4     
============================================
+ Hits          33446    33930     +484     
+ Misses        12468    11950     -518     
- Partials       2218     2250      +32     
Impacted Files Coverage Δ Complexity Δ
.../org/apache/hadoop/hdds/scm/pipeline/Pipeline.java 85.71% <100.00%> (+0.20%) 44.00 <0.00> (+1.00)
.../org/apache/hadoop/ozone/om/helpers/OmKeyInfo.java 86.25% <100.00%> (+0.33%) 42.00 <0.00> (+2.00)
...adoop/ozone/om/helpers/OmKeyLocationInfoGroup.java 75.60% <100.00%> (+1.25%) 12.00 <2.00> (+1.00)
...g/apache/hadoop/ozone/om/helpers/OzoneAclUtil.java 81.91% <100.00%> (+1.23%) 39.00 <4.00> (+2.00)
...adoop/ozone/om/request/key/OMKeyCommitRequest.java 97.00% <100.00%> (ø) 18.00 <0.00> (+1.00)
...p/ozone/om/ratis/utils/OzoneManagerRatisUtils.java 67.44% <0.00%> (-19.13%) 39.00% <0.00%> (ø%)
...che/hadoop/ozone/om/ratis/OMRatisSnapshotInfo.java 83.33% <0.00%> (-10.67%) 7.00% <0.00%> (-5.00%)
...ache/hadoop/ozone/om/codec/S3SecretValueCodec.java 90.90% <0.00%> (-9.10%) 3.00% <0.00%> (-1.00%)
.../apache/hadoop/ozone/om/OMDBCheckpointServlet.java 66.26% <0.00%> (-4.27%) 8.00% <0.00%> (-2.00%)
...zone/container/common/volume/MutableVolumeSet.java 75.00% <0.00%> (-0.90%) 39.00% <0.00%> (-1.00%)
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53395a0...495271e. Read the comment docs.

@maobaolong
Copy link
Member Author

This PR only modify the documents, it cannot fail the tests, so we should collect these fail test and mark as ignore, we can open it until we prove the test recover to strong and better.

[INFO] Running org.apache.hadoop.ozone.client.rpc.TestDeleteWithSlowFollower
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 28.865 s <<< FAILURE! - in org.apache.hadoop.ozone.client.rpc.TestDeleteWithSlowFollower
[ERROR] testDeleteKeyWithSlowFollower(org.apache.hadoop.ozone.client.rpc.TestDeleteWithSlowFollower)  Time elapsed: 0.152 s  <<< FAILURE!
java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertNotNull(Assert.java:621)
	at org.junit.Assert.assertNotNull(Assert.java:631)
	at org.apache.hadoop.ozone.client.rpc.TestDeleteWithSlowFollower.testDeleteKeyWithSlowFollower(TestDeleteWithSlowFollower.java:225)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
	at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
	at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384)
	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345)
	at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126)
	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418)

@maobaolong
Copy link
Member Author

@elek Please take a look at this PR, i think this document can be useful to learn how to use Ozone CSI interface.

Copy link
Member

@elek elek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Thanks to write it down.

Minore comment: I would add some more hints to install the cluster (use the right directory). (See below).

@maobaolong
Copy link
Member Author

@elek Thank you for your suggestion, I've accepted and committed.

@maobaolong maobaolong requested a review from elek June 24, 2020 14:40
Copy link
Member

@elek elek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Thanks the update @maobaolong

@elek elek merged commit a89ff6d into apache:master Jun 24, 2020
errose28 added a commit to errose28/ozone that referenced this pull request Jun 25, 2020
* upstream/master: (56 commits)
  HDDS-3264. Fix TestCSMMetrics.java. (apache#1120)
  HDDS-3858. Remove support to start Ozone and HDFS datanodes in the same JVM (apache#1117)
  HDDS-3704. Update all the documentation to use ozonefs-hadoop2/3 instead of legacy/current (apache#1099)
  HDDS-3773. Add OMDBDefinition to define structure of om.db. (apache#1076)
  Revert "HDDS-3263. Fix TestCloseContainerByPipeline.java. (apache#1119)" (apache#1126)
  HDDS-3821. Disable Ozone SPNEGO should not fall back to hadoop.http.a… (apache#1101)
  HDDS-3819. OzoneManager#listVolumeByUser ignores userName parameter when ACL is enabled (apache#1087)
  HDDS-3779. Add csi interface documents to show how to use ozone csi (apache#1059)
  HDDS-3857. Datanode in compose/ozonescripts can't be started (apache#1116)
  HDDS-3430. Enable TestWatchForCommit test cases. (apache#1114)
  HDDS-3263. Fix TestCloseContainerByPipeline.java. (apache#1119)
  HDDS-3512. s3g multi-part-upload saved incorrect content using streaming (apache#1092)
  HDDS-3836. Modify ContainerPlacementPolicyFactory JavaDoc (apache#1097)
  HDDS-3780. Replace the imagePullPolicy from always to IfNotPresent (apache#1055)
  HDDS-3847. Change OMNotLeaderException logging to DEBUG (apache#1118)
  HDDS-3745. Improve OM and SCM performance with 64% by avoid collect datanode information to s3g (apache#1031)
  HDDS-3286. BasicOzoneFileSystem  support batchDelete. (apache#814)
  HDDS-3850. Update the admin document to let user know how to show the status of all rules. (apache#1109)
  HDDS-3848. Add ratis.thirdparty.version in main pom.xml (apache#1108)
  HDDS-3815. Avoid buffer copy in ContainerCommandRequestProto. (apache#1085)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants