Skip to content

HDDS-3711. Handle inner classes in SCMRatisRequest and SCMRatisResponse #1016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timmylicheng merged 1 commit into from
Jun 4, 2020
Merged

HDDS-3711. Handle inner classes in SCMRatisRequest and SCMRatisResponse #1016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMRatisRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ public Message encode() throws InvalidProtocolBufferException {
final List<MethodArgument> args = new ArrayList<>();
for (Object argument : arguments) {
final MethodArgument.Builder argBuilder = MethodArgument.newBuilder();
argBuilder.setType(argument.getClass().getCanonicalName());
argBuilder.setType(argument.getClass().getName());
if (argument instanceof GeneratedMessage) {
argBuilder.setValue(((GeneratedMessage) argument).toByteString());
} else if (argument instanceof ProtocolMessageEnum) {
Expand Down
2 changes: 1 addition & 1 deletion hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMRatisResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ public static Message encode(final Object result)

final SCMRatisResponseProto response =
SCMRatisResponseProto.newBuilder()
.setType(result.getClass().getCanonicalName())
.setType(result.getClass().getName())
.setValue(value)
.build();
return Message.valueOf(
Expand Down