HDDS-3711. Handle inner classes in SCMRatisRequest and SCMRatisResponse #1016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dineshchitlangia
approved these changes
Jun 4, 2020
Contributor
dineshchitlangia
left a comment
dineshchitlangia
left a comment
There was a problem hiding this comment.
+1 , pending CI
Thanks @nandakumar131
Contributor
|
+1 pending on CI |
mukul1987
approved these changes
Jun 4, 2020
Contributor
|
Merged in. Thanks @nandakumar131 for contribution. |
timmylicheng
pushed a commit
that referenced
this pull request
Jun 10, 2020
…se. (#1016) Merge in. Thanks @nandakumar131 for the contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently creating class object for inner class fails with
ClassNotFoundException. We have to handle inner class instantiation.What is the link to the Apache JIRA
HDDS-3711
How was this patch tested?
Manually tested.