ORC-1593: Set orc.compression.zstd.level to 3 by default
#1760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
orc.compression.zstd.level to 3 by default
dongjoon-hyun
added a commit
that referenced
this pull request
Jan 17, 2024
### What changes were proposed in this pull request? This PR aims to set `orc.compression.zstd.level` to 3 by default. ### Why are the changes needed? To prevent a regression from ORC 1.9.x **ORC 1.9** ``` data/generated//taxi: total 2196176 drwxr-xr-x 5 dongjoon staff 160B Jan 17 08:02 . drwxr-xr-x 5 dongjoon staff 160B Jan 17 08:07 .. -rw-r--r-- 1 dongjoon staff 299M Jan 17 08:03 orc.zstd ``` **ORC 2.0** ``` -rw-r--r-- 1 dongjoon staff 334M Jan 17 07:56 orc.zstd (level 1) -rw-r--r-- 1 dongjoon staff 299M Jan 17 08:16 orc.zstd (level 3) -rw-r--r-- 1 dongjoon staff 302M Jan 17 08:21 orc.zstd (level 4) -rw-r--r-- 1 dongjoon staff 300M Jan 17 08:27 orc.zstd (level 5) ``` ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #1760 from dongjoon-hyun/ORC-1593. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 3f2a0b3) Signed-off-by: Dongjoon Hyun <[email protected]>
|
Thanks @dongjoon-hyun . The default compression levels of aircompressor used by ORC and zstd-jni used by parquet are both level 3. |
|
Ya, thank you for checking. |
dongjoon-hyun
added a commit
to apache/spark
that referenced
this pull request
Mar 8, 2024
### What changes were proposed in this pull request? This PR aims to Upgrade Apache ORC to 2.0.0 for Apache Spark 4.0.0. Apache ORC community has 3-year support policy which is longer than Apache Spark. It's aligned like the following. - Apache ORC 2.0.x <-> Apache Spark 4.0.x - Apache ORC 1.9.x <-> Apache Spark 3.5.x - Apache ORC 1.8.x <-> Apache Spark 3.4.x - Apache ORC 1.7.x (Supported) <-> Apache Spark 3.3.x (End-Of-Support) ### Why are the changes needed? **Release Note** - https://github.com/apache/orc/releases/tag/v2.0.0 **Milestone** - https://github.com/apache/orc/milestone/20?closed=1 - apache/orc#1728 - apache/orc#1801 - apache/orc#1498 - apache/orc#1627 - apache/orc#1497 - apache/orc#1509 - apache/orc#1554 - apache/orc#1708 - apache/orc#1733 - apache/orc#1760 - apache/orc#1743 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #45443 from dongjoon-hyun/SPARK-44115. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
sweisdb
pushed a commit
to sweisdb/spark
that referenced
this pull request
Apr 1, 2024
### What changes were proposed in this pull request? This PR aims to Upgrade Apache ORC to 2.0.0 for Apache Spark 4.0.0. Apache ORC community has 3-year support policy which is longer than Apache Spark. It's aligned like the following. - Apache ORC 2.0.x <-> Apache Spark 4.0.x - Apache ORC 1.9.x <-> Apache Spark 3.5.x - Apache ORC 1.8.x <-> Apache Spark 3.4.x - Apache ORC 1.7.x (Supported) <-> Apache Spark 3.3.x (End-Of-Support) ### Why are the changes needed? **Release Note** - https://github.com/apache/orc/releases/tag/v2.0.0 **Milestone** - https://github.com/apache/orc/milestone/20?closed=1 - apache/orc#1728 - apache/orc#1801 - apache/orc#1498 - apache/orc#1627 - apache/orc#1497 - apache/orc#1509 - apache/orc#1554 - apache/orc#1708 - apache/orc#1733 - apache/orc#1760 - apache/orc#1743 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45443 from dongjoon-hyun/SPARK-44115. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to set
orc.compression.zstd.levelto 3 by default.Why are the changes needed?
To prevent a regression from ORC 1.9.x
ORC 1.9
ORC 2.0
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.