ORC-1251: Use Hadoop Vectored IO #1708
Closed
+52
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamhyun
changed the title
|
I added |
| @@ -103,8 +106,7 @@ public OrcProto.StripeFooter readStripeFooter(StripeInformation stripe) throws I | |||
| public BufferChunkList readFileData(BufferChunkList range, | |||
| boolean doForceDirect | |||
| ) throws IOException { | |||
| RecordReaderUtils.readDiskRanges(file, zcr, range, doForceDirect, minSeekSize, | |||
| minSeekSizeTolerance); | |||
| RecordReaderUtils.readDiskRangesVectored(file, range, doForceDirect); | |||
There was a problem hiding this comment.
Got it. I believe it's okay to use Hadoop Vectored IO only from Apache ORC 2.0.0.
|
I fixed the checkstyle issue. |
There was a problem hiding this comment.
I finished my second-round review and simplified the logic a little, @williamhyun . I believe this PR is ready for further integration testing. Thank you so much!
|
Given that the patch size is small, we can test more after merging. Feel free to merge, @williamhyun . |
|
Let me merge this with the following authorship. |
|
Thanks, everyone for finishing this up. |
cxzl25
pushed a commit
to cxzl25/orc
that referenced
this pull request
Jan 11, 2024
### What changes were proposed in this pull request? This PR aims to use `Hadoop Vectored IO` always in Apache ORC 2.0.0. ### Why are the changes needed? Apache ORC 2.0.0 is ready to use this new Hadoop feature. - apache#1509 - apache#1554 - [Hadoop Vectored IO Presentation](https://docs.google.com/presentation/d/1U5QRN4etbM7gkbnGO3OW4sCfUZx9LqJN/) > Works great everywhere; radical benefit in object stores ### How was this patch tested? Pass the CIs. Closes apache#1708 from williamhyun/hadoopvectorized. Lead-authored-by: William Hyun <[email protected]> Co-authored-by: Dongjoon Hyun <[email protected]> Co-authored-by: HarshitGupta11 <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
added a commit
to apache/spark
that referenced
this pull request
Mar 8, 2024
### What changes were proposed in this pull request? This PR aims to Upgrade Apache ORC to 2.0.0 for Apache Spark 4.0.0. Apache ORC community has 3-year support policy which is longer than Apache Spark. It's aligned like the following. - Apache ORC 2.0.x <-> Apache Spark 4.0.x - Apache ORC 1.9.x <-> Apache Spark 3.5.x - Apache ORC 1.8.x <-> Apache Spark 3.4.x - Apache ORC 1.7.x (Supported) <-> Apache Spark 3.3.x (End-Of-Support) ### Why are the changes needed? **Release Note** - https://github.com/apache/orc/releases/tag/v2.0.0 **Milestone** - https://github.com/apache/orc/milestone/20?closed=1 - apache/orc#1728 - apache/orc#1801 - apache/orc#1498 - apache/orc#1627 - apache/orc#1497 - apache/orc#1509 - apache/orc#1554 - apache/orc#1708 - apache/orc#1733 - apache/orc#1760 - apache/orc#1743 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #45443 from dongjoon-hyun/SPARK-44115. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
sweisdb
pushed a commit
to sweisdb/spark
that referenced
this pull request
Apr 1, 2024
### What changes were proposed in this pull request? This PR aims to Upgrade Apache ORC to 2.0.0 for Apache Spark 4.0.0. Apache ORC community has 3-year support policy which is longer than Apache Spark. It's aligned like the following. - Apache ORC 2.0.x <-> Apache Spark 4.0.x - Apache ORC 1.9.x <-> Apache Spark 3.5.x - Apache ORC 1.8.x <-> Apache Spark 3.4.x - Apache ORC 1.7.x (Supported) <-> Apache Spark 3.3.x (End-Of-Support) ### Why are the changes needed? **Release Note** - https://github.com/apache/orc/releases/tag/v2.0.0 **Milestone** - https://github.com/apache/orc/milestone/20?closed=1 - apache/orc#1728 - apache/orc#1801 - apache/orc#1498 - apache/orc#1627 - apache/orc#1497 - apache/orc#1509 - apache/orc#1554 - apache/orc#1708 - apache/orc#1733 - apache/orc#1760 - apache/orc#1743 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45443 from dongjoon-hyun/SPARK-44115. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to use
Hadoop Vectored IOalways in Apache ORC 2.0.0.Why are the changes needed?
Apache ORC 2.0.0 is ready to use this new Hadoop feature.
How was this patch tested?
Pass the CIs.