Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Ability to not build examples during the build of the cpp package. #9832

Merged
merged 1 commit into from
Feb 20, 2018

Conversation

b0noI
Copy link
Contributor

@b0noI b0noI commented Feb 20, 2018

Description

Not everyone need to build all the examples together with the cpp_package. Not building examples saves time and several Gig of data.


add_subdirectory(example)
if(NOT DO_NOT_BUILD_EXAMPLES)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

naming seems kind of generic and not specific to cop-package

what current use cases don’t build?
for test target probably they should build?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cjolivier01 yep, I kept the name generic deliberately, since if you do not need examples, probably you do not need them in all targets, so I hope the flag will be adopted as needed in other places. But if you think we need to make it more concrete, I'm okay with it.

what current use cases don’t build?

Examples can consume several Gb after building. And also they consumes time to build. It make sense not to build them if there no explicit need.

for test target probably they should build?

Yes, you are right, I do need to refactor IF statement to reflect this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@cjolivier01 cjolivier01 merged commit 28bc3c2 into apache:master Feb 20, 2018
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants