Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

typo in cpp-package/CMakeLists.txt #10742

Closed
sl1pkn07 opened this issue Apr 29, 2018 · 6 comments
Closed

typo in cpp-package/CMakeLists.txt #10742

sl1pkn07 opened this issue Apr 29, 2018 · 6 comments
Labels
Build

Comments

@sl1pkn07
Copy link
Contributor

sl1pkn07 commented Apr 29, 2018 •
edited
Loading

https://github.com/apache/incubator-mxnet/blob/6bef58a920506e6cc2848ffd4ec3b4d5bce6120a/cpp-package/CMakeLists.txt#L19

should be if(BUILD_CPP_EXAMPLES) ? or if(WITH_EXAMPLE)

greetings
@nswamy
Copy link
Member

nswamy commented May 1, 2018 •
edited
Loading

seems like its doing the right NOT and DO_NOT ==> build with examples. sure, naming could been better. see the PR
#9832

@nswamy nswamy closed this as completed May 1, 2018
@nswamy nswamy added the Invalid label May 1, 2018
@sl1pkn07
Copy link
Contributor Author

sl1pkn07 commented May 1, 2018 •
edited
Loading

this option is not exposed in cmake options (gmake-gui), advanced or simple view) and is always builded by default

@nswamy nswamy added Build and removed Invalid labels May 1, 2018
@nswamy
Copy link
Member

nswamy commented May 1, 2018

I see, thanks for explaining.
@marcoabreu can you help fix this?

@nswamy nswamy reopened this May 1, 2018
@marcoabreu marcoabreu self-assigned this May 3, 2018
@sl1pkn07
Copy link
Contributor Author

hi, ani notice of this?

greetings

@marcoabreu marcoabreu removed their assignment Nov 10, 2019
@marcoabreu
Copy link
Contributor

Sorry, seems like I lost track of this issue. I currently don't have time to work on this issue, would you mind submitting a PR @sl1pkn07 ?

@sl1pkn07
Copy link
Contributor Author

oh, no, you not. I.

seems fixed in #14562

closing

greetings and sorry the noise

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Build
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sl1pkn07 @nswamy @marcoabreu