Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.9.x] LICENSE and CI fixes for 1.9 release #20626

Merged
merged 24 commits into from
Oct 7, 2021
Merged

[v1.9.x] LICENSE and CI fixes for 1.9 release #20626

merged 24 commits into from
Oct 7, 2021

Conversation

josephevans
Copy link
Contributor

@josephevans josephevans commented Oct 1, 2021 •
edited
Loading

Update LICENSE to include symlinks in include/dmlc licensed under non-ASF-2.0 licenses.

Fix docker build issues with Let's Encrypt CA expiration.

Fix perl package dependency issue with PDL.

Part of #20616

@mxnet-bot
Copy link

Hey @josephevans , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-gpu, centos-cpu, website, windows-cpu, miscellaneous, edge, unix-cpu, clang, windows-gpu, unix-gpu, sanity]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Oct 1, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Oct 2, 2021
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 2, 2021
@josephevans josephevans changed the title [v1.9.x] Update LICENSE [v1.9.x] LICENSE and CI fixes for 1.9 release Oct 2, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 2, 2021
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Oct 2, 2021
@mseth10 mseth10 added the pr-work-in-progress PR is still work in progress label Oct 7, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Oct 7, 2021
@josephevans
Attempt to fix windows build parameters with MKLDNN builds - do not u…
b64dd38 
…se debug builds when linking against MKLDNN.
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 7, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Oct 7, 2021
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Oct 7, 2021
@bartekkuncer
Copy link
Contributor

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

Unauthorized access detected.
Only following 3 categories can trigger CI :
PR Author, MXNet Committer, Jenkins Admin.

@mseth10 mseth10 added pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress labels Oct 7, 2021
@josephevans josephevans merged commit 7d09efc into apache:v1.9.x Oct 7, 2021
@josephevans josephevans deleted the license_fixes4_v1.9.x branch October 7, 2021 17:56
josephevans added a commit to josephevans/mxnet that referenced this pull request Oct 7, 2021
@josephevans
[v1.9.x] LICENSE and CI fixes for 1.9 release (apache#20626)
127669b 
* Update LICENSE to include symlinks in include/dmlc licensed under non-ASF-2.0 licenses.

* Update ca-certificates package on centos7 due to let's encrypt recent issue (see https://blog.devgenius.io/rhel-centos-7-fix-for-lets-encrypt-change-8af2de587fe4)

* Update PDL package before installing PDL::CCS to prevent dependency issue.

* Install latest ca-certificates package on aarch64 as well.

* Change libtiff download URL to http to prevent let's encrypt CA chain issue.

* update Dockerfile.build.ubuntu_cpu_jekyll

* Use http to download libcurl to avoid let's encrypt intermediate CA cert expiration issue.

* Lock down perl PDL version to specific version to prevent test failures.

* No need to source rvm.sh in environment now that we are using a different container.

* Update license_header.py tool to trigger error when two licenses are found.

* Remove expired CA cert from ubuntu14.04 containers.

* Revert "Change libtiff download URL to http to prevent let's encrypt CA chain issue."

This reverts commit 3ae1192.

* Revert "Use http to download libcurl to avoid let's encrypt intermediate CA cert expiration issue."

This reverts commit 92432a6.

* Back off retry count for windows builds to reduce cost.

* Split test_hybrid_static_memory_switching() into 3 tests in order to isolate failures.

* Skip mkldnn test, tracking at apache#20643.

* Fix lint

* Attempt to fix windows build parameters with MKLDNN builds - do not use debug builds when linking against MKLDNN.

* Revert "Update ca-certificates package on centos7 due to let's encrypt recent issue (see https://blog.devgenius.io/rhel-centos-7-fix-for-lets-encrypt-change-8af2de587fe4)"

This reverts commit 8b64859.

* Add back change after revert.

* Revert "Fix lint"

This reverts commit 34b430c.

* Revert "Skip mkldnn test, tracking at apache#20643."

This reverts commit f45a6e3.

* Revert "Split test_hybrid_static_memory_switching() into 3 tests in order to isolate failures."

This reverts commit 23db9ba.

* Revert changing windows build flags.

Co-authored-by: Wei Chu <[email protected]>
@josephevans josephevans mentioned this pull request Oct 7, 2021
Merged
josephevans added a commit that referenced this pull request Oct 8, 2021
@josephevans
[v1.x]Backport #20626 from v1.9.x branch (#20644)
e2a4488 
* [v1.9.x] LICENSE and CI fixes for 1.9 release (#20626)

* Update LICENSE to include symlinks in include/dmlc licensed under non-ASF-2.0 licenses.

* Update ca-certificates package on centos7 due to let's encrypt recent issue (see https://blog.devgenius.io/rhel-centos-7-fix-for-lets-encrypt-change-8af2de587fe4)

* Update PDL package before installing PDL::CCS to prevent dependency issue.

* Install latest ca-certificates package on aarch64 as well.

* Change libtiff download URL to http to prevent let's encrypt CA chain issue.

* update Dockerfile.build.ubuntu_cpu_jekyll

* Use http to download libcurl to avoid let's encrypt intermediate CA cert expiration issue.

* Lock down perl PDL version to specific version to prevent test failures.

* No need to source rvm.sh in environment now that we are using a different container.

* Update license_header.py tool to trigger error when two licenses are found.

* Remove expired CA cert from ubuntu14.04 containers.

* Revert "Change libtiff download URL to http to prevent let's encrypt CA chain issue."

This reverts commit 3ae1192.

* Revert "Use http to download libcurl to avoid let's encrypt intermediate CA cert expiration issue."

This reverts commit 92432a6.

* Back off retry count for windows builds to reduce cost.

* Split test_hybrid_static_memory_switching() into 3 tests in order to isolate failures.

* Skip mkldnn test, tracking at #20643.

* Fix lint

* Attempt to fix windows build parameters with MKLDNN builds - do not use debug builds when linking against MKLDNN.

* Revert "Update ca-certificates package on centos7 due to let's encrypt recent issue (see https://blog.devgenius.io/rhel-centos-7-fix-for-lets-encrypt-change-8af2de587fe4)"

This reverts commit 8b64859.

* Add back change after revert.

* Revert "Fix lint"

This reverts commit 34b430c.

* Revert "Skip mkldnn test, tracking at #20643."

This reverts commit f45a6e3.

* Revert "Split test_hybrid_static_memory_switching() into 3 tests in order to isolate failures."

This reverts commit 23db9ba.

* Revert changing windows build flags.

Co-authored-by: Wei Chu <[email protected]>

* Update openssl package in ubuntu_core.sh (used in ubuntu 16.04 images) to avoid bug triggered by let's encrypt expired ca cert.

Co-authored-by: Wei Chu <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@waytrue17 waytrue17 waytrue17 approved these changes

@barry-jin barry-jin barry-jin approved these changes

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@marcoabreu marcoabreu Awaiting requested review from marcoabreu marcoabreu is a code owner

@szha szha Awaiting requested review from szha szha is a code owner

@anirudh2290 anirudh2290 Awaiting requested review from anirudh2290

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@josephevans @mxnet-bot @bartekkuncer @waytrue17 @barry-jin @mseth10