-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[RFC] [Licensing] Address ASF Feedback for 1.9.0.rc7 release #20616
Comments
I've created a PR (#20598) to address the first three items and the last item (and checked as complete.) Please review with any comments/suggestions/concerns. This PR also adds a Github workflow (thanks to @barry-jin for help) to use Apache's latest license checking tool, skywalking-eyes. |
I manually checked all source files in
Any help manually auditing the rest of the source tree would be greatly appreciated. |
Fix the first 3 items in #20616 * Remove ASF2.0 license and properly list under 3-clause BSD files in LICENSE for np_einsum files. * Fix license category for deformable_convolution files. * Update list of Apache-2.0 licensed files. * Add files to LICENSE that fall under Apache 2.0 license. * Add include symlinks and other ASF2 files to LICENSE. * Remove extra line. * Add numpy einsum files (licensed under bsd 3-clause) to rat-excludes. * Mention include/nnvm in LICENSE file. * Remove files from LICENSE with clear ASF-2.0 license headers, added by accident based on skywalking-eyes faulty results. * Move header guards to below license header section, so skywalking-eyes tool recognizes ASF-2.0 header. * Fix formatting with license header. * Fix license section for FindJeMalloc.cmake, move protoc-gen-mypy.py to Apache-2.0 licensed files. * Clearly indicate caffe subdirectory's licensing model in LICENSE. * Add skywalking-eyes config to repo. * Add skywalking-eyes config (.licenserv.yaml) to rat-excludes. * Add skywalking-eyes license checker into Github workflow. * Remove caffe subdir from LICENSE and license-check config whitelist, since it is no longer in the repo. * Remove duplicate entries in LICENSE - leave in Caffe license section.
Fix the first 3 items in apache#20616 * Remove ASF2.0 license and properly list under 3-clause BSD files in LICENSE for np_einsum files. * Fix license category for deformable_convolution files. * Update list of Apache-2.0 licensed files. * Add files to LICENSE that fall under Apache 2.0 license. * Add include symlinks and other ASF2 files to LICENSE. * Remove extra line. * Add numpy einsum files (licensed under bsd 3-clause) to rat-excludes. * Mention include/nnvm in LICENSE file. * Remove files from LICENSE with clear ASF-2.0 license headers, added by accident based on skywalking-eyes faulty results. * Move header guards to below license header section, so skywalking-eyes tool recognizes ASF-2.0 header. * Fix formatting with license header. * Fix license section for FindJeMalloc.cmake, move protoc-gen-mypy.py to Apache-2.0 licensed files. * Clearly indicate caffe subdirectory's licensing model in LICENSE. * Add skywalking-eyes config to repo. * Add skywalking-eyes config (.licenserv.yaml) to rat-excludes. * Add skywalking-eyes license checker into Github workflow. * Remove caffe subdir from LICENSE and license-check config whitelist, since it is no longer in the repo. * Remove duplicate entries in LICENSE - leave in Caffe license section.
* [v1.9.x] license updates (#20598) Fix the first 3 items in #20616 * Remove ASF2.0 license and properly list under 3-clause BSD files in LICENSE for np_einsum files. * Fix license category for deformable_convolution files. * Update list of Apache-2.0 licensed files. * Add files to LICENSE that fall under Apache 2.0 license. * Add include symlinks and other ASF2 files to LICENSE. * Remove extra line. * Add numpy einsum files (licensed under bsd 3-clause) to rat-excludes. * Mention include/nnvm in LICENSE file. * Remove files from LICENSE with clear ASF-2.0 license headers, added by accident based on skywalking-eyes faulty results. * Move header guards to below license header section, so skywalking-eyes tool recognizes ASF-2.0 header. * Fix formatting with license header. * Fix license section for FindJeMalloc.cmake, move protoc-gen-mypy.py to Apache-2.0 licensed files. * Clearly indicate caffe subdirectory's licensing model in LICENSE. * Add skywalking-eyes config to repo. * Add skywalking-eyes config (.licenserv.yaml) to rat-excludes. * Add skywalking-eyes license checker into Github workflow. * Remove caffe subdir from LICENSE and license-check config whitelist, since it is no longer in the repo. * Remove duplicate entries in LICENSE - leave in Caffe license section. * Remove extra characters accidentally added to Apache license header.
I have manually checked all the header files in include/onednn(mkldnn), include/dlpack, include/dmlc, include/mshadow and found one more issue:
|
I looked into the |
At this point, we have manually reviewed all the source files in Since we don't believe there are any additional outstanding license issues, I think we should move forward with the v1.9.0 release. Does anyone have comments or issues? |
Thanks Joe and Zhenghui and others who helped on the efforts in thoroughly addressing the license issues. Also thanks to @kezhenxu94 for sharing the great license checker tool from the skywalking community. I have a question from reviewing the LICENSE file from the master branch:
|
Thanks for the feedback @szha. I addressed the two issues you list above in #20709. I also audited the LICENSE file in v1.x branch and ensured everything listed is in the proper section. After reading through https://infra.apache.org/licensing-howto.html, I also wanted to ensure that we comply to licensing terms for binary distributions - we need to include any copyright clauses and provide the associated license text in any binary distribution of MXNet. In order to achieve this, I created a number of LICENSE.*.txt files that includes the required text. These files should automatically get included in pip wheels (see https://github.com/apache/incubator-mxnet/blob/v1.x/tools/pip/setup.py#L94-L95) to fulfill terms. This is how the TVM project includes license text, although MXNet has many more files under different licenses. I would appreciate a review or comments on this approach. |
Created a PR for the v1.9.x branch: #20722 |
Thanks Joe & community for continuing to push this along.
Given that this release process has drawn on quite a while, would it be possible to pull in PR #20137 [1]? This goes along with #20107 [2] that was part of 1.9.0.rc7 [3] for deconvolution support. I would be happy to do the backporting.
Thanks!
Sam
[1] #20137
[2] #20107
[3] https://github.com/apache/incubator-mxnet/releases/tag/1.9.0.rc7
On 11/2/21, 7:12 PM, "Joe Evans" ***@***.***> wrote:
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
Once #20722 is merged, I would like to close this issue and move forward with 1.9.0.rc8. I've converted the single outstanding task of updating the license tool to a new item for tracking (#20723).
…--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#20616 (comment)
|
Merged #20726 into v1.9.x, we should be ready for another release candidate. Closing this issue. |
Problem statement
Based on the feedback from ASF on our vote to release MXNet v1.9.0.rc7, we still have a few licensing issues that caused a -1 vote, which prevents us from moving forward with the release.
Based on the RC7 voting thread, the following licensing issues are still outstanding:
Files incorrectly have ASF headers. These files are all copyrighted by NumPy developers and released under the 3-clause BSD license. We should not have added the ASF header and kept the original license headers intact, and mention this by including it in the "3-clause BSD license" section in LICENSE.
Some files are not correctly listed in LICENSE. For example, these files contain a "Copyright Microsoft" line but are released under ASF-2 or MIT license. These need to be properly mentioned in LICENSE:
As ASF noted, not all files were checked and there could be others that are missed. In order to better identify licensing issues in the future, we should extend the use of automated tools (such as skywalking-eyes).
References
The text was updated successfully, but these errors were encountered: