Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[BUGFIX] Pip Build: use runtime.Features instead of manual check for mkldnn headers (#19195) #19928

Merged
merged 1 commit into from
Feb 22, 2021
Merged

[BUGFIX] Pip Build: use runtime.Features instead of manual check for mkldnn headers (#19195) #19928

merged 1 commit into from
Feb 22, 2021

Conversation

access2rohit
Copy link
Contributor

@access2rohit access2rohit commented Feb 19, 2021 •
edited
Loading

Backport #19195 as a part of effort #19911

  • use runtime Features instead of manual check

  • move mxnet package closer to where its used

  • dropping cuda9.1

@ChaiBapchya
[BUGFIX] Pip Build: use runtime.Features instead of manual check for …
c9e13e4 
…mkldnn headers (apache#19195)

* use runtime Features instead of manual check

* move mxnet package closer to where its used
@mxnet-bot
Copy link

Hey @access2rohit , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-cpu, unix-gpu, centos-gpu, website, clang, windows-gpu, miscellaneous, sanity, edge, centos-cpu, unix-cpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@access2rohit
Copy link
Contributor Author

@josephevans @ChaiBapchya Can you review ?

@lanking520 lanking520 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Feb 19, 2021
@access2rohit access2rohit mentioned this pull request Feb 19, 2021
Closed
13 tasks
@lanking520 lanking520 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 19, 2021
ChaiBapchya
ChaiBapchya reviewed Feb 20, 2021
View reviewed changes
tools/pip/setup.py
@@ -142,22 +142,16 @@ def skip_markdown_comments(md):
libraries.append('CUDA-10.0')
elif variant.startswith('CU92'):
libraries.append('CUDA-9.2')
elif variant.startswith('CU91'):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we dropping support for all cuda till 9? I guess yes [since cuda11 has launched and we support till latest major version-1]. Can we update the PR title to also reflect the same? Since currently it just talks about mkldnn and this PR changes things more than that.

ChaiBapchya
ChaiBapchya approved these changes Feb 20, 2021
View reviewed changes
Copy link
Contributor

@ChaiBapchya ChaiBapchya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment about PR title, rest looks good

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-merge Review and CI is complete. Ready to Merge labels Feb 22, 2021
@ChaiBapchya ChaiBapchya merged commit ea342cc into apache:v1.x Feb 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ChaiBapchya ChaiBapchya ChaiBapchya approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@access2rohit @mxnet-bot @ChaiBapchya @lanking520