Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[BUGFIX] Pip Build: use runtime.Features instead of manual check for mkldnn headers #19195

Merged
merged 2 commits into from
Sep 24, 2020

Conversation

ChaiBapchya
Copy link
Contributor

@ChaiBapchya ChaiBapchya commented Sep 20, 2020

Description

Title
Refer: https://github.com/apache/incubator-mxnet/pull/18797/files#r463170714

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • CD [pypi build creation]

@mxnet-bot
Copy link

Hey @ChaiBapchya , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [edge, unix-cpu, windows-cpu, clang, windows-gpu, website, miscellaneous, sanity, centos-cpu, unix-gpu, centos-gpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@ChaiBapchya
Copy link
Contributor Author

@mseth10

@ChaiBapchya
Copy link
Contributor Author

@mxnet-bot run ci [miscellaneous]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [miscellaneous]

@szha szha requested a review from leezu September 24, 2020 20:25
@leezu leezu merged commit bd0846a into apache:master Sep 24, 2020
@access2rohit access2rohit mentioned this pull request Feb 17, 2021
13 tasks
access2rohit pushed a commit to access2rohit/incubator-mxnet that referenced this pull request Feb 19, 2021
…mkldnn headers (apache#19195)

* use runtime Features instead of manual check

* move mxnet package closer to where its used
@ChaiBapchya ChaiBapchya deleted the switch_mkldnn_condition_pip_setup branch February 20, 2021 18:33
ChaiBapchya added a commit that referenced this pull request Feb 22, 2021
…mkldnn headers (#19195) (#19928)

* use runtime Features instead of manual check

* move mxnet package closer to where its used

Co-authored-by: Chaitanya Prakash Bapat <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants