Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] Attempt to fix v1.x CI issues. #19872

Merged
merged 8 commits into from
Feb 10, 2021
Merged

[v1.x] Attempt to fix v1.x CI issues. #19872

merged 8 commits into from
Feb 10, 2021

Conversation

josephevans
Copy link
Contributor

@josephevans josephevans commented Feb 9, 2021 •
edited
Loading

Description

Update to python 3.7, added numpy requirement for onnx dependencies so gluoncv doesn't overwrite the numpy version we need.

@mxnet-bot
Copy link

Hey @josephevans , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [website, clang, edge, centos-gpu, unix-gpu, windows-cpu, centos-cpu, unix-cpu, windows-gpu, miscellaneous, sanity]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 9, 2021
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Feb 9, 2021
waytrue17
waytrue17 approved these changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@waytrue17 waytrue17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Zha0q1
Zha0q1 approved these changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@Zha0q1 Zha0q1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!!

@Zha0q1 Zha0q1 mentioned this pull request Feb 9, 2021
Closed
@lanking520 lanking520 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Feb 9, 2021
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Feb 9, 2021
@josephevans josephevans mentioned this pull request Feb 10, 2021
Closed
@lanking520 lanking520 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Feb 10, 2021
access2rohit
access2rohit approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@access2rohit access2rohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lanking520 lanking520 added pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 10, 2021
@sandeep-krishnamurthy sandeep-krishnamurthy merged commit bf9e62a into apache:v1.x Feb 10, 2021
@josephevans josephevans deleted the v1.x_ci_fixes branch February 10, 2021 19:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Zha0q1 Zha0q1 Zha0q1 approved these changes

@access2rohit access2rohit access2rohit approved these changes

@waytrue17 waytrue17 waytrue17 approved these changes

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@marcoabreu marcoabreu Awaiting requested review from marcoabreu marcoabreu is a code owner

@anirudh2290 anirudh2290 Awaiting requested review from anirudh2290

@eric-haibin-lin eric-haibin-lin Awaiting requested review from eric-haibin-lin

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@josephevans @mxnet-bot @Zha0q1 @access2rohit @waytrue17 @sandeep-krishnamurthy @lanking520