Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[WIP] Revert v1.x #19869

Closed
wants to merge 1 commit into from
Closed

[WIP] Revert v1.x #19869

wants to merge 1 commit into from

Conversation

Zha0q1
Copy link
Contributor

@Zha0q1 Zha0q1 commented Feb 8, 2021

unix-cpu/gpu are failing on v1.x. This pr checks if 031dc5b is the cause

@mxnet-bot
Copy link

Hey @Zha0q1 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-gpu, windows-cpu, clang, unix-gpu, centos-gpu, miscellaneous, centos-cpu, sanity, unix-cpu, website, edge]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added the pr-work-in-progress PR is still work in progress label Feb 8, 2021
@szha
Copy link
Member

szha commented Feb 8, 2021

@Zha0q1 unix-gpu job has been failing in my PR #19799 before #19670 was merged.

@Zha0q1
Copy link
Contributor Author

Zha0q1 commented Feb 9, 2021

@szha Thanks for the info! @waytrue17 is creating an issue and the current oncall will look into this

@Zha0q1
Copy link
Contributor Author

Zha0q1 commented Feb 9, 2021

Closing pr for now since we confirmed the ci issue was not caused by that pr

@Zha0q1 Zha0q1 closed this Feb 9, 2021
@access2rohit
Copy link
Contributor

access2rohit commented Feb 9, 2021

@Zha0q1 unix-gpu job has been failing in my PR #19799 before #19670 was merged.

@szha I looked at your PR and our commit log of the v1.x branch. After the PR #19670 there is only one PR merged(#19837) and its CPU unittests passed 4 days ago. Your PR passed its first 13 days ago and then remaining 3 re-runs started 2 days ago. I am currently running unix_CPU CI w/ and W/o #19670 to verify. Will update shortly

@Zha0q1
Copy link
Contributor Author

Zha0q1 commented Feb 9, 2021

@Zha0q1 unix-gpu job has been failing in my PR #19799 before #19670 was merged.

@szha I looked at your PR and our commit log of the v1.x branch. After the PR #19670 there is only one PR merged(#19837) and its CPU unittests passed 4 days ago. Your PR passed its first 13 days ago and then remaining 3 re-runs started 2 days ago. I am currently running unix_CPU CI w/ and W/o #19670 to verify. Will update shortly

I think Sheng was right that #19670 was not the cause of the ci issue. In this PR even after reverting #19670 the failure still happened. @josephevans opened a pr #19872 to attempt to fix the issue

@access2rohit
Copy link
Contributor

ok ... i will stop then. Since you already verified that reverting the PR doesn't fix the issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-work-in-progress PR is still work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants