Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix nightly CD for python docker image releases #19772

Merged
merged 29 commits into from
Feb 27, 2021
Merged

Fix nightly CD for python docker image releases #19772

merged 29 commits into from
Feb 27, 2021

Conversation

mseth10
Copy link
Contributor

@mseth10 mseth10 commented Jan 21, 2021 •
edited
Loading

Description

This PR makes multiple changes to fix the nightly CD pipeline for python docker image releases.

  • Change push target from dockerhub to ecr public repository
  • Update all base images for docker build from ubuntu16 to ubuntu18
  • Use deadsnakes python package
  • Remove unused mxnet_lib/dynamic pipeline

@mxnet-bot
Copy link

Hey @mseth10 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [edge, sanity, centos-cpu, centos-gpu, windows-cpu, unix-cpu, windows-gpu, unix-gpu, website, clang, miscellaneous]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Jan 21, 2021
@lanking520 lanking520 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Jan 22, 2021
leezu
leezu reviewed Jan 22, 2021
View reviewed changes
Copy link
Contributor

@leezu leezu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As part of this work, can we reconsider the publication strategy? Currently nightly builds are pushed to dockerhub, which is not compatible with ASF policy. Instead, can you configure the job to only push on approved release tags?

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Jan 22, 2021
@mseth10 mseth10 changed the title Update cd python Fix CD pipeline for nightly docker images Jan 22, 2021
@lanking520 lanking520 added pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 23, 2021
@lanking520 lanking520 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Feb 26, 2021
@mseth10 mseth10 requested a review from leezu February 26, 2021 07:55
@lanking520 lanking520 added pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 26, 2021
sandeep-krishnamurthy
sandeep-krishnamurthy reviewed Feb 26, 2021
View reviewed changes
cd/utils/mxnet_base_image.sh Outdated
@@ -31,7 +31,7 @@ case ${mxnet_variant} in
echo "nvidia/cuda:11.0-cudnn8-runtime-ubuntu16.04"
;;
cu112*)
echo "nvidia/cuda:11.2-cudnn8-runtime-ubuntu16.04"
echo "nvidia/cuda:11.2.1-cudnn8-runtime-ubuntu16.04"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ubuntu 16.04 is EOL by April, 2021 (https://ubuntu.com/about/release-cycle), Can we please move to ubuntu 18.04 or 20.04?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to ubuntu 18.04 for all docker base images

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-review PR is waiting for code review labels Feb 26, 2021
@lanking520 lanking520 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Feb 26, 2021
access2rohit
access2rohit approved these changes Feb 26, 2021
View reviewed changes
Copy link
Contributor

@access2rohit access2rohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lanking520 lanking520 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Feb 26, 2021
@mseth10 mseth10 merged commit 9d1e290 into apache:master Feb 27, 2021
mseth10 added a commit to mseth10/incubator-mxnet that referenced this pull request Feb 27, 2021
@mseth10
Fix nightly CD for python docker image releases (apache#19772)
f04ec20 
* install wget

* test cd docker in ci

* install docker

* install python3-dev and gcc

* remove docker testing from ci

* remove python3-dev

* ecr target

* skip build test

* adding back python3-dev for make

* remove dynamic and pypi stages for testing

* install build-essential

* install zlib

* update python version

* update ld library path

* install openssl

* update test packages for python3.7

* remove call to deleted safe_docker_run.py

* hardcode region for public ecr repo

* use deadsnakes to install python

* revert dependency change

* refactor ecr login

* update ecr repo jenkins global var

* cleanup

* update docker authentication

* add ecr repo

* add back pypi and tests

* remove unused libmxnet pipeline

* update cu112 base docker

* update base docker images to ub18
mseth10 added a commit to mseth10/incubator-mxnet that referenced this pull request Feb 27, 2021
@mseth10
Fix nightly CD for python docker image releases (apache#19772)
5a9b7d0 
* install wget

* test cd docker in ci

* install docker

* install python3-dev and gcc

* remove docker testing from ci

* remove python3-dev

* ecr target

* skip build test

* adding back python3-dev for make

* remove dynamic and pypi stages for testing

* install build-essential

* install zlib

* update python version

* update ld library path

* install openssl

* update test packages for python3.7

* remove call to deleted safe_docker_run.py

* hardcode region for public ecr repo

* use deadsnakes to install python

* revert dependency change

* refactor ecr login

* update ecr repo jenkins global var

* cleanup

* update docker authentication

* add ecr repo

* add back pypi and tests

* remove unused libmxnet pipeline

* update cu112 base docker

* update base docker images to ub18
mseth10 added a commit that referenced this pull request Mar 2, 2021
@mseth10 @szha
[v1.x] Fix nightly CD for python docker image releases (#19774)
9b8a5e6 
* [CD] switch CD_RELEASE_JOB_NAME from global env var to job argument (#17775)

* Fix nightly CD for python docker image releases (#19772)

* install wget

* test cd docker in ci

* install docker

* install python3-dev and gcc

* remove docker testing from ci

* remove python3-dev

* ecr target

* skip build test

* adding back python3-dev for make

* remove dynamic and pypi stages for testing

* install build-essential

* install zlib

* update python version

* update ld library path

* install openssl

* update test packages for python3.7

* remove call to deleted safe_docker_run.py

* hardcode region for public ecr repo

* use deadsnakes to install python

* revert dependency change

* refactor ecr login

* update ecr repo jenkins global var

* cleanup

* update docker authentication

* add ecr repo

* add back pypi and tests

* remove unused libmxnet pipeline

* update cu112 base docker

* update base docker images to ub18

* differentiate tag prefix for v1.x

Co-authored-by: Sheng Zha <[email protected]>
@mseth10 mseth10 deleted the update_cd_python branch March 2, 2021 01:35
mseth10 added a commit to mseth10/incubator-mxnet that referenced this pull request Mar 5, 2021
@mseth10 @szha
[v1.x] Fix nightly CD for python docker image releases (apache#19774)
fd2c442 
* [CD] switch CD_RELEASE_JOB_NAME from global env var to job argument (apache#17775)

* Fix nightly CD for python docker image releases (apache#19772)

* install wget

* test cd docker in ci

* install docker

* install python3-dev and gcc

* remove docker testing from ci

* remove python3-dev

* ecr target

* skip build test

* adding back python3-dev for make

* remove dynamic and pypi stages for testing

* install build-essential

* install zlib

* update python version

* update ld library path

* install openssl

* update test packages for python3.7

* remove call to deleted safe_docker_run.py

* hardcode region for public ecr repo

* use deadsnakes to install python

* revert dependency change

* refactor ecr login

* update ecr repo jenkins global var

* cleanup

* update docker authentication

* add ecr repo

* add back pypi and tests

* remove unused libmxnet pipeline

* update cu112 base docker

* update base docker images to ub18

* differentiate tag prefix for v1.x

Co-authored-by: Sheng Zha <[email protected]>
mseth10 added a commit that referenced this pull request Mar 8, 2021
@mseth10 @szha
[v1.8.x] Cherry-pick CD pipelines refactor with fix for docker images…
dd4661a 
… pipeline (#19989)

* [v1.x] Fix nightly CD for python docker image releases (#19774)

* [CD] switch CD_RELEASE_JOB_NAME from global env var to job argument (#17775)

* Fix nightly CD for python docker image releases (#19772)

* install wget

* test cd docker in ci

* install docker

* install python3-dev and gcc

* remove docker testing from ci

* remove python3-dev

* ecr target

* skip build test

* adding back python3-dev for make

* remove dynamic and pypi stages for testing

* install build-essential

* install zlib

* update python version

* update ld library path

* install openssl

* update test packages for python3.7

* remove call to deleted safe_docker_run.py

* hardcode region for public ecr repo

* use deadsnakes to install python

* revert dependency change

* refactor ecr login

* update ecr repo jenkins global var

* cleanup

* update docker authentication

* add ecr repo

* add back pypi and tests

* remove unused libmxnet pipeline

* update cu112 base docker

* update base docker images to ub18

* differentiate tag prefix for v1.x

Co-authored-by: Sheng Zha <[email protected]>

* pass version param (#19982)

* remove cu112 changes

Co-authored-by: Sheng Zha <[email protected]>
mseth10 added a commit to mseth10/incubator-mxnet that referenced this pull request Mar 15, 2021
@mseth10 @szha
[v1.8.x] Cherry-pick CD pipelines refactor with fix for docker images…
d45343c 
… pipeline (apache#19989)

* [v1.x] Fix nightly CD for python docker image releases (apache#19774)

* [CD] switch CD_RELEASE_JOB_NAME from global env var to job argument (apache#17775)

* Fix nightly CD for python docker image releases (apache#19772)

* install wget

* test cd docker in ci

* install docker

* install python3-dev and gcc

* remove docker testing from ci

* remove python3-dev

* ecr target

* skip build test

* adding back python3-dev for make

* remove dynamic and pypi stages for testing

* install build-essential

* install zlib

* update python version

* update ld library path

* install openssl

* update test packages for python3.7

* remove call to deleted safe_docker_run.py

* hardcode region for public ecr repo

* use deadsnakes to install python

* revert dependency change

* refactor ecr login

* update ecr repo jenkins global var

* cleanup

* update docker authentication

* add ecr repo

* add back pypi and tests

* remove unused libmxnet pipeline

* update cu112 base docker

* update base docker images to ub18

* differentiate tag prefix for v1.x

Co-authored-by: Sheng Zha <[email protected]>

* pass version param (apache#19982)

* remove cu112 changes

Co-authored-by: Sheng Zha <[email protected]>
leezu pushed a commit that referenced this pull request Mar 25, 2021
@mseth10 @leezu
Fix nightly CD for python docker image releases (#19772)
0f4be44 
* install wget

* test cd docker in ci

* install docker

* install python3-dev and gcc

* remove docker testing from ci

* remove python3-dev

* ecr target

* skip build test

* adding back python3-dev for make

* remove dynamic and pypi stages for testing

* install build-essential

* install zlib

* update python version

* update ld library path

* install openssl

* update test packages for python3.7

* remove call to deleted safe_docker_run.py

* hardcode region for public ecr repo

* use deadsnakes to install python

* revert dependency change

* refactor ecr login

* update ecr repo jenkins global var

* cleanup

* update docker authentication

* add ecr repo

* add back pypi and tests

* remove unused libmxnet pipeline

* update cu112 base docker

* update base docker images to ub18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sandeep-krishnamurthy sandeep-krishnamurthy sandeep-krishnamurthy left review comments

@josephevans josephevans josephevans left review comments

@Zha0q1 Zha0q1 Zha0q1 approved these changes

@access2rohit access2rohit access2rohit approved these changes

@leezu leezu Awaiting requested review from leezu

Assignees
No one assigned
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mseth10 @mxnet-bot @leezu @sandeep-krishnamurthy @josephevans @Zha0q1 @access2rohit @lanking520