Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[CD] switch CD_RELEASE_JOB_NAME from global env var to job argument #17775

Merged
merged 1 commit into from
Mar 13, 2020

Conversation

szha
Copy link
Member

@szha szha commented Mar 5, 2020

Description

switch CD_RELEASE_JOB_NAME from global env var to job argument

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • switch CD_RELEASE_JOB_NAME from global env var to job argument

Comments

  • This is preparation work for the nightly releases for v1.x and v2.0.
  • Once merged, I will cherry pick this change to the v1.x branch.

Copy link
Contributor

@perdasilva perdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I would still suggest to look into multi-branch jobs though...

@szha
Copy link
Member Author

szha commented Mar 6, 2020

@perdasilva thanks for the suggestion. I looked at the multi branch feature and it seems to pick up all new branches and creates jobs accordingly. At the moment, we just need to build nightly for v1.x and master so manual job would suffice for now.

@leezu
Copy link
Contributor

leezu commented Mar 6, 2020

retriggered unix-gpu

@szha szha merged commit 34010ea into apache:master Mar 13, 2020
@szha szha deleted the cd_arg branch March 13, 2020 06:11
MoisesHer pushed a commit to MoisesHer/incubator-mxnet that referenced this pull request Apr 10, 2020
mseth10 pushed a commit to mseth10/incubator-mxnet that referenced this pull request Feb 26, 2021
mseth10 pushed a commit to mseth10/incubator-mxnet that referenced this pull request Feb 26, 2021
mseth10 added a commit that referenced this pull request Mar 2, 2021
* [CD] switch CD_RELEASE_JOB_NAME from global env var to job argument (#17775)

* Fix nightly CD for python docker image releases (#19772)

* install wget

* test cd docker in ci

* install docker

* install python3-dev and gcc

* remove docker testing from ci

* remove python3-dev

* ecr target

* skip build test

* adding back python3-dev for make

* remove dynamic and pypi stages for testing

* install build-essential

* install zlib

* update python version

* update ld library path

* install openssl

* update test packages for python3.7

* remove call to deleted safe_docker_run.py

* hardcode region for public ecr repo

* use deadsnakes to install python

* revert dependency change

* refactor ecr login

* update ecr repo jenkins global var

* cleanup

* update docker authentication

* add ecr repo

* add back pypi and tests

* remove unused libmxnet pipeline

* update cu112 base docker

* update base docker images to ub18

* differentiate tag prefix for v1.x

Co-authored-by: Sheng Zha <[email protected]>
mseth10 added a commit to mseth10/incubator-mxnet that referenced this pull request Mar 5, 2021
* [CD] switch CD_RELEASE_JOB_NAME from global env var to job argument (apache#17775)

* Fix nightly CD for python docker image releases (apache#19772)

* install wget

* test cd docker in ci

* install docker

* install python3-dev and gcc

* remove docker testing from ci

* remove python3-dev

* ecr target

* skip build test

* adding back python3-dev for make

* remove dynamic and pypi stages for testing

* install build-essential

* install zlib

* update python version

* update ld library path

* install openssl

* update test packages for python3.7

* remove call to deleted safe_docker_run.py

* hardcode region for public ecr repo

* use deadsnakes to install python

* revert dependency change

* refactor ecr login

* update ecr repo jenkins global var

* cleanup

* update docker authentication

* add ecr repo

* add back pypi and tests

* remove unused libmxnet pipeline

* update cu112 base docker

* update base docker images to ub18

* differentiate tag prefix for v1.x

Co-authored-by: Sheng Zha <[email protected]>
mseth10 added a commit that referenced this pull request Mar 8, 2021
… pipeline (#19989)

* [v1.x] Fix nightly CD for python docker image releases (#19774)

* [CD] switch CD_RELEASE_JOB_NAME from global env var to job argument (#17775)

* Fix nightly CD for python docker image releases (#19772)

* install wget

* test cd docker in ci

* install docker

* install python3-dev and gcc

* remove docker testing from ci

* remove python3-dev

* ecr target

* skip build test

* adding back python3-dev for make

* remove dynamic and pypi stages for testing

* install build-essential

* install zlib

* update python version

* update ld library path

* install openssl

* update test packages for python3.7

* remove call to deleted safe_docker_run.py

* hardcode region for public ecr repo

* use deadsnakes to install python

* revert dependency change

* refactor ecr login

* update ecr repo jenkins global var

* cleanup

* update docker authentication

* add ecr repo

* add back pypi and tests

* remove unused libmxnet pipeline

* update cu112 base docker

* update base docker images to ub18

* differentiate tag prefix for v1.x

Co-authored-by: Sheng Zha <[email protected]>

* pass version param (#19982)

* remove cu112 changes

Co-authored-by: Sheng Zha <[email protected]>
mseth10 added a commit to mseth10/incubator-mxnet that referenced this pull request Mar 15, 2021
… pipeline (apache#19989)

* [v1.x] Fix nightly CD for python docker image releases (apache#19774)

* [CD] switch CD_RELEASE_JOB_NAME from global env var to job argument (apache#17775)

* Fix nightly CD for python docker image releases (apache#19772)

* install wget

* test cd docker in ci

* install docker

* install python3-dev and gcc

* remove docker testing from ci

* remove python3-dev

* ecr target

* skip build test

* adding back python3-dev for make

* remove dynamic and pypi stages for testing

* install build-essential

* install zlib

* update python version

* update ld library path

* install openssl

* update test packages for python3.7

* remove call to deleted safe_docker_run.py

* hardcode region for public ecr repo

* use deadsnakes to install python

* revert dependency change

* refactor ecr login

* update ecr repo jenkins global var

* cleanup

* update docker authentication

* add ecr repo

* add back pypi and tests

* remove unused libmxnet pipeline

* update cu112 base docker

* update base docker images to ub18

* differentiate tag prefix for v1.x

Co-authored-by: Sheng Zha <[email protected]>

* pass version param (apache#19982)

* remove cu112 changes

Co-authored-by: Sheng Zha <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants