Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Add test case for oneDNN RNN #19465

Merged
merged 1 commit into from
Nov 6, 2020
Merged

Add test case for oneDNN RNN #19465

merged 1 commit into from
Nov 6, 2020

Conversation

bgawrych
Copy link
Contributor

@bgawrych bgawrych commented Nov 2, 2020

Description

This PR enables test case which produces seg faults with oneDNN < 1.6.5
#19308
#19451

Problem should be fixed with: #19444

@mxnet-bot
Copy link

Hey @bgawrych , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [edge, windows-cpu, clang, website, centos-cpu, miscellaneous, unix-cpu, windows-gpu, unix-gpu, centos-gpu, sanity]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 2, 2020
@bgawrych
Copy link
Contributor Author

bgawrych commented Nov 3, 2020

@mxnet-bot run ci [edge, unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [edge, unix-cpu]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 3, 2020
@bgawrych
Copy link
Contributor Author

bgawrych commented Nov 4, 2020

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 4, 2020
@bgawrych
Copy link
Contributor Author

bgawrych commented Nov 6, 2020

@anko-intel @pengzhao-intel Can we merge it?

pengzhao-intel
pengzhao-intel approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@pengzhao-intel pengzhao-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pengzhao-intel pengzhao-intel merged commit f3c69c1 into apache:master Nov 6, 2020
@anko-intel
Copy link
Contributor

LGTM

vidyaravipati pushed a commit to vidyaravipati/incubator-mxnet that referenced this pull request Nov 11, 2020
@bgawrych
Add test case for oneDNN RNN (apache#19465)
64da9d2
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pengzhao-intel pengzhao-intel pengzhao-intel approved these changes

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bgawrych @mxnet-bot @anko-intel @pengzhao-intel @lanking520