Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Remove test metric perf #18331

Closed
wants to merge 28 commits into from
Closed

Conversation

acphile
Copy link
Contributor

@acphile acphile commented May 15, 2020

related to #18330
We think that "test_metric_perf" does not enforce anything and currently there are speed issues related to using mxnet.numpy. We should simply delete the test because it only prints the elapsed time.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

Hey @acphile , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-cpu, centos-cpu, windows-gpu, unix-cpu, centos-gpu, unix-gpu, clang, website, sanity, miscellaneous, edge]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@acphile acphile changed the title No test metric perf Remove test metric perf May 15, 2020
@ChaiBapchya
Copy link
Contributor

ChaiBapchya commented May 15, 2020

Quick history check reveals this file was added by @safrooze in #9705
Can we move this to nightly since that was planned? or do we get rid of it altogether?

@leezu
Copy link
Contributor

leezu commented May 15, 2020

I think we should integrate it in the performance benchmark. Currently there is not mechanism to monitor the results

@szha
Copy link
Member

szha commented May 15, 2020

I'm moving it to benchmark scripts in #18252

@rondogency
Copy link
Contributor

@leezu the performance benchmark we are running is focusing on model level performance on end to end training/inference, this one is more related to opperf to test components

@leezu
Copy link
Contributor

leezu commented May 18, 2020

Let's close this as it's moved to benchmark scripts in #18252

@leezu leezu closed this May 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants