Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[CI] run operator tests with naive engine #18252

Merged
merged 6 commits into from
May 17, 2020
Merged

[CI] run operator tests with naive engine #18252

merged 6 commits into from
May 17, 2020

Conversation

szha
Copy link
Member

@szha szha commented May 6, 2020

Description

run operator tests with naive engine

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • run operator tests with naive engine

@mxnet-bot
Copy link

Hey @szha , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-gpu, miscellaneous, windows-cpu, website, sanity, windows-gpu, clang, centos-cpu, unix-cpu, edge, unix-gpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@szha szha force-pushed the naive_eng branch 2 times, most recently from f721ca4 to e585f73 Compare May 8, 2020 22:52
@szha szha force-pushed the naive_eng branch 6 times, most recently from a009067 to 41fd8b1 Compare May 15, 2020 05:11
@szha szha marked this pull request as ready for review May 15, 2020 17:21
@marcoabreu
Copy link
Contributor

What's our strategy to test multi threaded engine?

@szha
Copy link
Member Author

szha commented May 15, 2020

@marcoabreu all but the operator unit tests still run on threaded engine.

This was referenced May 15, 2020
Closed
Closed
sxjscience
sxjscience approved these changes May 17, 2020
View reviewed changes
Copy link
Member

@sxjscience sxjscience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szha szha merged commit 10b6b48 into apache:master May 17, 2020
@szha szha deleted the naive_eng branch May 17, 2020 02:04
@mseth10
Copy link
Contributor

mseth10 commented May 19, 2020

hey @szha , this commit breaks the nightly CD pipeline.

tests/python/unittest/test_extensions.py::test_subgraph should be SKIPPED, but after this commit it is not getting skipped.

Basically, this change is not working as expected: 10b6b48#diff-460d06cb3af2af996c5ec259b086712fR100

Can you please fix this?

@leezu leezu mentioned this pull request May 19, 2020
Merged
AntiZpvoh pushed a commit to AntiZpvoh/incubator-mxnet that referenced this pull request Jul 6, 2020
@szha @AntiZpvoh
[CI] run operator tests with naive engine (apache#18252)
ba0a265 
* run operator tests with naive engine

* fix take tests

* update skip mark

* fix cuda error reset

* adjust tests

* disable parallel testing and naive engine for mkl/mkldnn apache#18244
@DickJC123
Copy link
Contributor

I realize this PR is over a year old, but does anyone remember the original problem being solved, i.e. why can't the operator unittests run with the threaded_engine_per_device? Seems like if we're only running the unittests once, it should be with the default engine.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leezu leezu leezu left review comments

@sxjscience sxjscience sxjscience approved these changes

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@marcoabreu marcoabreu Awaiting requested review from marcoabreu marcoabreu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@szha @mxnet-bot @marcoabreu @mseth10 @DickJC123 @leezu @sxjscience