Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[numpy] fix npx.softmax for 0-sized inputs #18158

Merged
merged 1 commit into from
Apr 27, 2020

Conversation

Yiyan66
Copy link
Contributor

@Yiyan66 Yiyan66 commented Apr 24, 2020

Description

pr #17796
issue #17792 #17990

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

Hey @Yiyan66 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-cpu, centos-cpu, unix-cpu, windows-gpu, clang, unix-gpu, sanity, website, centos-gpu, miscellaneous, edge]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@Yiyan66
Copy link
Contributor Author

Yiyan66 commented Apr 26, 2020

@mxnet-bot run ci [windows-gpu, unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu, unix-gpu]

@haojin2 haojin2 merged commit 8816b35 into apache:master Apr 27, 2020
zheyuye pushed a commit to zheyuye/incubator-mxnet that referenced this pull request May 10, 2020
@bgawrych
Copy link
Contributor

bgawrych commented Jul 6, 2020

@Yiyan66 @yzhliu Do you think this fix should be cherry-picked to 1.x?
Without it my change #18602 is failing with floating point exception

AntiZpvoh pushed a commit to AntiZpvoh/incubator-mxnet that referenced this pull request Jul 6, 2020
bgawrych pushed a commit to bgawrych/incubator-mxnet that referenced this pull request Jul 14, 2020
bgawrych pushed a commit to bgawrych/incubator-mxnet that referenced this pull request Jul 20, 2020
bgawrych pushed a commit to bgawrych/incubator-mxnet that referenced this pull request Jul 31, 2020
TaoLv pushed a commit that referenced this pull request Aug 3, 2020
…) (#18708)

* [v1.x] Backport of fix npx.softmax for 0-sized inputs (#18158)

Co-authored-by: Hao Jin <[email protected]>

* Fix softmax, logsoftmax failed on empty ndarray (#18602)

* Fix failing empty array (log_)softmax

* Modify test for npx (log_)softmax

* Fix softmax, logsoftmax backward failed on empty ndarray (#18710)

Co-authored-by: Yiyan66 <[email protected]>
Co-authored-by: Hao Jin <[email protected]>
Co-authored-by: Bart Gawrych <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants