Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Revert "[MXNET-#16795] Byteps-KVStore" #17998

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

eric-haibin-lin
Copy link
Member

@eric-haibin-lin eric-haibin-lin commented Apr 8, 2020

This reverts commit c244f9f.

Description

BytePS with recently MXNet would lead to segfault and the test added to CI does not properly catch it.

#17555

@ChaokunChang

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

…xnet as new type of kvstore backend (apache#17555)"

This reverts commit c244f9f.
@leezu
Copy link
Contributor

leezu commented Apr 8, 2020

Why does the test fail to catch the bug?

@eric-haibin-lin
Copy link
Member Author

The error code was not properly returned from the byteps launcher

@eric-haibin-lin eric-haibin-lin merged commit 6cc990c into apache:master Apr 8, 2020
@eric-haibin-lin eric-haibin-lin deleted the revert branch July 22, 2020 20:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants