Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Skip test_multi_worker_dataloader_release_pool #17797

Merged
merged 2 commits into from
Mar 18, 2020
Merged

Skip test_multi_worker_dataloader_release_pool #17797

merged 2 commits into from
Mar 18, 2020

Conversation

haojin2
Copy link
Contributor

@haojin2 haojin2 commented Mar 9, 2020

Description

...to unblock many PR on the CI.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Skip test_multi_worker_dataloader_release_pool

Comments

@haojin2 haojin2 added the CI label Mar 9, 2020
@haojin2 haojin2 requested a review from zhreshold March 9, 2020 22:25
@leezu
Copy link
Contributor

leezu commented Mar 9, 2020 •
edited
Loading

Does the test fail on any other platform besides OS X? Currently OS X status test is optional, so failing OS X tests doesn't block PRs. We can disable the test nevertheless, but it may be forgotten and not fixed.

Tracking issue: #17782

@haojin2
Copy link
Contributor Author

haojin2 commented Mar 9, 2020

@leezu I still think it's still necessary to skip this for now in case it masks the failures of other tests that comes after this test in the test sequence.

@leezu
Copy link
Contributor

leezu commented Mar 9, 2020

Thanks for clarification. Let's disable it. I'm still at loss why this only happens on OS X.
Would be great if anyone with a Mac could help debug this issue.

@zhreshold
Copy link
Member

I think you can check for mac explicitly in test and disable it rather than skip for all platforms

@haojin2
Copy link
Contributor Author

haojin2 commented Mar 9, 2020

@zhreshold Good idea, I'll make changes in that way.

@haojin2 haojin2 force-pushed the flaky_test_multi_worker_dataloader_release_pool branch from af2ca5d to e03d85e Compare March 9, 2020 23:07
@leezu leezu mentioned this pull request Mar 9, 2020
Open
@marcoabreu
Copy link
Contributor

Can we add a tracking issue in this PR as well as in the code?

@leezu leezu merged commit 41d534b into apache:master Mar 18, 2020
anirudh2290 added a commit to anirudh2290/mxnet that referenced this pull request Mar 27, 2020
@anirudh2290
Merge branch 'master' of https://github.com/apache/incubator-mxnet
ae654ba 
* 'master' of https://github.com/apache/incubator-mxnet: (192 commits)
  * impl - FFI for np einsum (apache#17869)
  [Numpy] FFI for diag/diagonal/diag_indices_from (apache#17789)
  [Numpy] Kron operator (apache#17323)
  cmake: Set DMLC_LOG_FATAL_THROW only for building mxnet and not for tvm (apache#17878)
  Add simplified HybridBlock.forward without F (apache#17530)
  Use FP32 copy of weights for norm (multitensor LAMB optimizer) (apache#17700)
  Use multi-tensor sumSQ in clip_global_norm (apache#17652)
  [Numpy] Add op fmax, fmin, fmod (apache#17567)
  Adding sparse support to MXTensor for custom operators (apache#17569)
  Update 3rdparty/mkldnn to v1.2.2 (apache#17313)
  Dynamic subgraph compile support (apache#17623)
  Refactor cpp-package CMakeLists.txt & add missing inference/imagenet_inference (apache#17835)
  staticbuild: Fix potential user-assisted execution of arbitrary code  (apache#17860)
  * FFI for np.argmax and np.argmin (apache#17843)
  ffi for roll/rot90 (apache#17861)
  Skip test_multi_worker_dataloader_release_pool on OS X (apache#17797)
  add ffi for full_like, binary (apache#17811)
  HybridBlock.export() to return created filenames (apache#17758)
  Fix SoftReLU fused operator numerical stability (apache#17849)
  CI: Test clang10 cpu & gpu builds with -WError (apache#17830)
  ...
MoisesHer pushed a commit to MoisesHer/incubator-mxnet that referenced this pull request Apr 10, 2020
@haojin2 @MoisesHer
Skip test_multi_worker_dataloader_release_pool on OS X (apache#17797)
a20b250 
Tracked in apache#17782
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request May 29, 2020
@haojin2 @anirudh2290
Skip test_multi_worker_dataloader_release_pool on OS X (apache#17797)
80c29dc 
Tracked in apache#17782
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leezu leezu leezu left review comments

@zhreshold zhreshold zhreshold approved these changes

Assignees
No one assigned
Labels
CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@haojin2 @leezu @zhreshold @marcoabreu