Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Update 3rdparty/mkldnn to v1.2.2 #17313

Merged
merged 29 commits into from
Mar 20, 2020
Merged

Update 3rdparty/mkldnn to v1.2.2 #17313

merged 29 commits into from
Mar 20, 2020

Conversation

TaoLv
Copy link
Member

@TaoLv TaoLv commented Jan 15, 2020

Description

Currently it's the release candidate for v1.2.0. Will change to formal release once it's published.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@TaoLv TaoLv requested a review from anirudh2290 as a code owner January 15, 2020 07:51
@TaoLv TaoLv mentioned this pull request Jan 16, 2020
Closed
@TaoLv TaoLv requested a review from szha as a code owner January 21, 2020 14:33
@TaoLv TaoLv added the MKLDNN label Jan 26, 2020
@TaoLv TaoLv changed the title [WIP] Update 3rdparty/mkldnn to v1.2.0 Update 3rdparty/mkldnn to v1.2.1 Feb 26, 2020
@TaoLv
Copy link
Member Author

TaoLv commented Feb 26, 2020

This is to upgrade the 3rdparty dependency to DNNL v1.2.1 and the changes are ready for review. Hope someone can help to retrigger the failing case. Thanks.

@TaoLv TaoLv requested a review from leezu as a code owner March 9, 2020 01:43
@leezu
Copy link
Contributor

leezu commented Mar 9, 2020

@TaoLv you can retrigger yourself.

  1. Click Login
    image

  2. Click the circular button in the upper right corner
    image

@TaoLv
Copy link
Member Author

TaoLv commented Mar 10, 2020

Thanks for reminding, @leezu. Yes, I just got the privilege for re-triggering CI jobs last week~

ciyongch
ciyongch reviewed Mar 16, 2020
View reviewed changes
tests/cpp/operator/mkldnn_test.cc
@@ -100,7 +100,7 @@ static void VerifyDefMem(const mkldnn::memory &mem) {

TEST(MKLDNN_UTIL_FUNC, MemFormat) {
// Check whether the number of format is correct.
CHECK_EQ(mkldnn_format_tag_last, 131);
CHECK_EQ(mkldnn_format_tag_last, 152);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where can we get this number? Or do we need to calculate this number manually when upgrading to a new version of DNNL?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need print this flag in cpp to get the value. This test was design to notify us if there are new formats added to dnnl so we need carefully check if these new formats break any integration code or the integration code need be improved to handle them.

@TaoLv
Copy link
Member Author

TaoLv commented Mar 19, 2020

I noticed that DNNL released the 1.2.2 patch release today. I'm going to update this PR to the latest release of the library.

@TaoLv TaoLv changed the title Update 3rdparty/mkldnn to v1.2.1 Update 3rdparty/mkldnn to v1.2.2 Mar 20, 2020
@szha szha merged commit 3667e9a into apache:master Mar 20, 2020
@szha
Copy link
Member

szha commented Mar 20, 2020

Note that master branch is now used for 2.x development. If this needs to be backported to 1.7, it needs to be done manually.

anirudh2290 added a commit to anirudh2290/mxnet that referenced this pull request Mar 27, 2020
@anirudh2290
Merge branch 'master' of https://github.com/apache/incubator-mxnet
ae654ba 
* 'master' of https://github.com/apache/incubator-mxnet: (192 commits)
  * impl - FFI for np einsum (apache#17869)
  [Numpy] FFI for diag/diagonal/diag_indices_from (apache#17789)
  [Numpy] Kron operator (apache#17323)
  cmake: Set DMLC_LOG_FATAL_THROW only for building mxnet and not for tvm (apache#17878)
  Add simplified HybridBlock.forward without F (apache#17530)
  Use FP32 copy of weights for norm (multitensor LAMB optimizer) (apache#17700)
  Use multi-tensor sumSQ in clip_global_norm (apache#17652)
  [Numpy] Add op fmax, fmin, fmod (apache#17567)
  Adding sparse support to MXTensor for custom operators (apache#17569)
  Update 3rdparty/mkldnn to v1.2.2 (apache#17313)
  Dynamic subgraph compile support (apache#17623)
  Refactor cpp-package CMakeLists.txt & add missing inference/imagenet_inference (apache#17835)
  staticbuild: Fix potential user-assisted execution of arbitrary code  (apache#17860)
  * FFI for np.argmax and np.argmin (apache#17843)
  ffi for roll/rot90 (apache#17861)
  Skip test_multi_worker_dataloader_release_pool on OS X (apache#17797)
  add ffi for full_like, binary (apache#17811)
  HybridBlock.export() to return created filenames (apache#17758)
  Fix SoftReLU fused operator numerical stability (apache#17849)
  CI: Test clang10 cpu & gpu builds with -WError (apache#17830)
  ...
MoisesHer pushed a commit to MoisesHer/incubator-mxnet that referenced this pull request Apr 10, 2020
@TaoLv @MoisesHer
Update 3rdparty/mkldnn to v1.2.2 (apache#17313)
fb45102 
* fix cpp test

* update to dnnl v1.2-rc

* pin rls-v1.2

* build dnnl with DNNL_ENABLE_CONCURRENT_EXEC=ON

* update rls-v1.2

* update to formal 1.2 release

* try patch

* fix rnn

* pin rls-v1.2

* dnnl v1.2.1

* dnnl v1.2.2
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request May 29, 2020
@TaoLv @anirudh2290
Update 3rdparty/mkldnn to v1.2.2 (apache#17313)
ef0974f 
* fix cpp test

* update to dnnl v1.2-rc

* pin rls-v1.2

* build dnnl with DNNL_ENABLE_CONCURRENT_EXEC=ON

* update rls-v1.2

* update to formal 1.2 release

* try patch

* fix rnn

* pin rls-v1.2

* dnnl v1.2.1

* dnnl v1.2.2
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ciyongch ciyongch ciyongch left review comments

@leezu leezu leezu approved these changes

@anirudh2290 anirudh2290 Awaiting requested review from anirudh2290

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
MKLDNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TaoLv @leezu @szha @ciyongch