Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Bump up additional scala 1.x branch to 1.7.0 #17764

Closed
wants to merge 1 commit into from

Conversation

zachgk
Copy link
Contributor

@zachgk zachgk commented Mar 4, 2020

Description

Add additional version number changes for Scala missed by #17741.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Copy link
Member

@szha szha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@zachgk
Copy link
Contributor Author

zachgk commented Mar 5, 2020

Dropping PR to master in favor of #17739. Will still continue PR to 1.x branch at #17765.

@zachgk zachgk closed this Mar 5, 2020
@zachgk zachgk deleted the bumpScala1.7.0 branch March 10, 2020 01:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants