Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

bump up 1.x branch to 1.7.0 #17741

Merged
merged 2 commits into from
Mar 3, 2020
Merged

bump up 1.x branch to 1.7.0 #17741

merged 2 commits into from
Mar 3, 2020

Conversation

szha
Copy link
Member

@szha szha commented Mar 2, 2020

Description

bump up 1.x branch to 1.7

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • bump up 1.x branch to 1.7

Comments

@gigasquid
Copy link
Member

Thanks for getting the PR together. I think one Clojure file got left out by accident. The main project.clj file https://github.com/apache/incubator-mxnet/blob/master/contrib/clojure-package/project.clj#L18

Do you mind adding? Or I can make a PR to your branch if you prefer.

@szha szha merged commit 458906b into apache:master Mar 3, 2020
szha added a commit that referenced this pull request Mar 3, 2020
* bump up 1.x branch to 1.7.0

* bump version for clojure
@leezu
Copy link
Contributor

leezu commented Mar 4, 2020

@szha Seems this was merged to the wrong branch and broke nightly tests

[2020-03-03T19:53:00.983Z] [ERROR] Failed to execute goal on project mxnet-scala-demo: Could not resolve dependencies for project Demo:mxnet-scala-demo:pom:1.0-SNAPSHOT: Failed to collect dependencies at org.apache.mxnet:mxnet-full_2.11-linux-x86_64-cpu:jar:[1.7.0-SNAPSHOT,): No versions available for org.apache.mxnet:mxnet-full_2.11-linux-x86_64-cpu:jar:[1.7.0-SNAPSHOT,) within specified range -> [Help 1]

@szha
Copy link
Member Author

szha commented Mar 4, 2020

@leezu I realized it afterwards and cherry-picked the change to 1.x. I think the problem here is that there's no new scala mxnet released yet. @lanking520 could you look into the status for the build?

@szha szha deleted the bump_v1 branch March 4, 2020 05:13
MoisesHer pushed a commit to MoisesHer/incubator-mxnet that referenced this pull request Apr 10, 2020
* bump up 1.x branch to 1.7.0

* bump version for clojure
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request May 29, 2020
* bump up 1.x branch to 1.7.0

* bump version for clojure
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants