This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
USE_JEMALLOC=OFF by default #17324
Merged
USE_JEMALLOC=OFF by default #17324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of jemalloc 5, jemalloc default build can not be used in libraries that are dlopened. However, libmxnet.so is dlopened by Python (ctypes). To use MXNet with jemalloc 5, users must not to system libjemalloc.so but must rather link to a libjemalloc compiled with special parameters to allow dlopen to work. jemalloc 5 is distributed as part of Ubuntu 18.10 and higher, as well as Debian Stable. Users on these systems will be unable to compile MXNet with USE_JEMALLOC=ON.
|
Should this be brought to the notice of dev community? I remember when certain build flag (MKLDNN/Large tensor) is to be toggled, it's discussed first. On other side, since this one toggles it off so I guess we can go ahead.. |
|
Thanks, I will send a mail to dev. |
marcoabreu
approved these changes
Jan 19, 2020
szha
approved these changes
Jan 20, 2020
5 tasks
szhengac
pushed a commit
to szhengac/mxnet
that referenced
this pull request
Jan 21, 2020
apache#17324) As of jemalloc 5, jemalloc default build can not be used in libraries that are dlopened. However, libmxnet.so is dlopened by Python (ctypes). To use MXNet with jemalloc 5, users must not link to system libjemalloc.so but must rather link to a libjemalloc compiled with DISABLE_INITIAL_EXEC_TLS
szhengac
pushed a commit
to szhengac/mxnet
that referenced
this pull request
Jan 21, 2020
apache#17324) As of jemalloc 5, jemalloc default build can not be used in libraries that are dlopened. However, libmxnet.so is dlopened by Python (ctypes). To use MXNet with jemalloc 5, users must not link to system libjemalloc.so but must rather link to a libjemalloc compiled with DISABLE_INITIAL_EXEC_TLS
szhengac
pushed a commit
to szhengac/mxnet
that referenced
this pull request
Jan 21, 2020
apache#17324) As of jemalloc 5, jemalloc default build can not be used in libraries that are dlopened. However, libmxnet.so is dlopened by Python (ctypes). To use MXNet with jemalloc 5, users must not link to system libjemalloc.so but must rather link to a libjemalloc compiled with DISABLE_INITIAL_EXEC_TLS
szhengac
pushed a commit
to szhengac/mxnet
that referenced
this pull request
Jan 21, 2020
apache#17324) As of jemalloc 5, jemalloc default build can not be used in libraries that are dlopened. However, libmxnet.so is dlopened by Python (ctypes). To use MXNet with jemalloc 5, users must not link to system libjemalloc.so but must rather link to a libjemalloc compiled with DISABLE_INITIAL_EXEC_TLS
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As of jemalloc 5, jemalloc default build can not be used in libraries that are dlopened. However, libmxnet.so is dlopened by Python (ctypes). To use MXNet with jemalloc 5, users must not to system libjemalloc.so but must rather link to a libjemalloc compiled with special parameters to allow dlopen to work.
jemalloc 5 is distributed as part of Ubuntu 18.10 and higher, as well as Debian Stable. Users on these systems will be unable to compile MXNet with USE_JEMALLOC=ON.
An alternative is to build jemalloc as part of our build. See #17121 for an implementation. Given the lack of review of #17121 and the reliance of a patched jemalloc version to allow integration into our build, let's first proceed with the current PR.
Changes