This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Include 3rdparty/jemalloc (Fix for Ubuntu 18.10+, Debian Stable, etc.) #17121
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As of jemalloc 5, jemalloc default build can not be used in libraries that
dlopen
ed. However,libmxnet.so
isdlopen
ed by Python (ctypes). We can thus not link to systemlibjemalloc.so
but must rather link to alibjemalloc
compiled as part of our build process.jemalloc 5 is distributed as part of Ubuntu 18.10 and higher, as well as Debian Stable.
Users on these systems will be unable to compile MXNet with
USE_JEMALLOC=ON
(which is the default).This PR contains the necessary changes.
Fixes #17145
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments
jemalloc
that adds CMake support. Once the patch is mainlined, we can switch to the official repo. The patch is currently hosted at https://github.com/leezu/jemalloc/tree/add/cmake-2019. All credits go to @mattsta (see Feature request: cmake support jemalloc/jemalloc#303)