Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix norm sparse fallback regression #17149

Merged
merged 1 commit into from
Dec 25, 2019

Conversation

haojin2
Copy link
Contributor

@haojin2 haojin2 commented Dec 23, 2019

Description

As title. On master branch

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@haojin2 haojin2 added the CI label Dec 23, 2019
@haojin2 haojin2 self-assigned this Dec 23, 2019
@haojin2 haojin2 changed the title [DO NOT REVIEW] [DO NOT MERGE] Dummy commit for testing CI Fix norm sparse fallback regression Dec 25, 2019
@haojin2 haojin2 added Bug Sparse and removed CI labels Dec 25, 2019
@haojin2
Copy link
Contributor Author

haojin2 commented Dec 25, 2019

@ptrendx This is the same fix as #17146 to master branch.

@haojin2 haojin2 added the R1.6.0 label Dec 25, 2019
@eric-haibin-lin eric-haibin-lin merged commit 2551a9d into apache:master Dec 25, 2019
eric-haibin-lin pushed a commit to eric-haibin-lin/mxnet that referenced this pull request Jan 2, 2020
eric-haibin-lin pushed a commit that referenced this pull request Jan 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants