Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix sparse L2Norm's fallback regression #17146

Closed
wants to merge 2 commits into from

Conversation

haojin2
Copy link
Contributor

@haojin2 haojin2 commented Dec 23, 2019

Description

Fix for #16060 in 1.6

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Fix incorrect condition check

Comments

test coverage already exists so no extra tests added.

@ptrendx
Copy link
Member

ptrendx commented Dec 23, 2019

What is the commit in master that corresponds to this fix?

@haojin2
Copy link
Contributor Author

haojin2 commented Dec 25, 2019

@ptrendx There's no fix in master yet, would you prefer this being PRed to master first?

@eric-haibin-lin
Copy link
Member

@ptrendx the PR to the master branch was merged #17149

@haojin2
Copy link
Contributor Author

haojin2 commented Dec 26, 2019

@leezu Edge build is failing, probably you should also port your change to the CI to v1.6.x branch

@eric-haibin-lin
Copy link
Member

eric-haibin-lin commented Jan 2, 2020

Opened another PR with this fix that passes CI: #17202

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants