Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Revert "Mkldnn fullyConnect bwd bug fix (#16890)" #16907

Merged
merged 2 commits into from
Nov 26, 2019

Conversation

TaoLv
Copy link
Member

@TaoLv TaoLv commented Nov 26, 2019

This reverts commit 436967b.

Flaky issue reported here: #16895 (comment)

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@haojin2
Copy link
Contributor

haojin2 commented Nov 26, 2019

@TaoLv Can you re-trigger your CI?

@wkcn wkcn merged commit 6c7ce24 into apache:master Nov 26, 2019
@wkcn
Copy link
Member

wkcn commented Nov 26, 2019

Merged. Thank you : )

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants