-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
enable mkldnn inner product backward or this may not take effect. |
To be more accurate, MKL-DNN FC backward path was not enabled before, so there is no bug of it in previously MXNet versions. This PR tries to enable it. |
|
@TaoLv @PatricZhao Does this impact 1.6? |
@ptrendx No, it should not affect 1.6.0 release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This reverts commit 436967b.
I'm going to revert this PR as it causes flaky issue reported here: #16895 (comment). @rongzha1 Could you please re-submit once the issue is fixed? Thanks. |
@rongzha1 Any update for this PR and the flaky CPP test? |
Can not reproduced in local machine, still not find the root cause. |
Description
fix mkldnn fc bwd bug due to data inplace
when data inplace, if do bwd_data will change src data which will lead bwd_weight calc error.
@PatricZhao @TaoLv @xinyu-intel
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments