Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Numpy] implement np.column_stack #16594

Merged
merged 26 commits into from
Oct 31, 2019
Merged

[Numpy] implement np.column_stack #16594

merged 26 commits into from
Oct 31, 2019

Conversation

vexilligera
Copy link
Contributor

Description

(Brief description on what this PR is about)
implement np.column_stack tentative pr

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@vexilligera vexilligera changed the title implement np.column_stack [Numpy] implement np.column_stack Oct 23, 2019
@haojin2 haojin2 self-assigned this Oct 23, 2019
@haojin2 haojin2 added the Numpy label Oct 23, 2019
reminisce
reminisce reviewed Oct 24, 2019
View reviewed changes
Copy link
Contributor

@reminisce reminisce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add column_stack to _NUMPY_ARRAY_FUNCTION_LIST and copy test cases from the official NumPy to test_numpy_interoperability.py.

python/mxnet/ndarray/numpy/_op.py Outdated Show resolved Hide resolved
tests/python/unittest/test_numpy_op.py Outdated Show resolved Hide resolved
@vexilligera
Copy link
Contributor Author

@haojin2 @reminisce
Hi, all fixed. Please have a look.

Ubuntu and others added 19 commits October 25, 2019 04:11
ci
cafc11a
ci
627081b
Merge branch 'master' of https://github.com/apache/incubator-mxnet
c9ed0d7
resolve conflict
cd7c793
ci
1f703c3
@xiezhq-hermann @haojin2
[Numpy] Numpy operator diff (#15906)
27bddf8 
* numpy diff operator implemented

append and prepend not supported yet

remove the prepend and append checking interface from the backend

refine the code, enrich the test set and all tests passed

registered the diff operator into npi scope

all tests passed

comments and minor modification

format codes and fix warning for sanity check

minor modification for sanity check

fix sanity

fix the tolerance bound of testing np.diff

resolve minor coding style issue

replace the given tests by random picking

minor fix

* interoperability test added
implement np.column_stack
9465e06
cpplint
7aa3797
remove column_stack from numpy interoperability test temporarily
48fc728
style and test fix
b819cfd
fix pylint and add interoperability test
a5c5202
fix doc string, add comment, remove dead code
c81d153
pylint
884428d
ci
f7f1f04
ci
08db148
ci
761149a
test
8ff47bf
rebase resolve conflicts
173c1f1
pylint
209acc2
@vexilligera
Copy link
Contributor Author

@haojin2

@haojin2 haojin2 merged commit f9baec9 into apache:master Oct 31, 2019
yajiedesign pushed a commit to yajiedesign/mxnet that referenced this pull request Nov 6, 2019
@vexilligera @yajiedesign
[Numpy] implement np.column_stack (apache#16594)
b410fdf 
* implement np.column_stack

* cpplint

* remove column_stack from numpy interoperability test temporarily

* style and test fix

* fix pylint and add interoperability test

* fix doc string, add comment, remove dead code

* pylint

* ci

* ci

* ci

* [Numpy] Numpy operator diff (apache#15906)

* numpy diff operator implemented

append and prepend not supported yet

remove the prepend and append checking interface from the backend

refine the code, enrich the test set and all tests passed

registered the diff operator into npi scope

all tests passed

comments and minor modification

format codes and fix warning for sanity check

minor modification for sanity check

fix sanity

fix the tolerance bound of testing np.diff

resolve minor coding style issue

replace the given tests by random picking

minor fix

* interoperability test added

* implement np.column_stack

* cpplint

* remove column_stack from numpy interoperability test temporarily

* style and test fix

* fix pylint and add interoperability test

* fix doc string, add comment, remove dead code

* pylint

* ci

* ci

* ci

* rebase resolve conflicts

* pylint
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@reminisce reminisce reminisce left review comments

@haojin2 haojin2 haojin2 approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees

@haojin2 haojin2

Labels
Numpy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vexilligera @reminisce @haojin2 @xiezhq-hermann