Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Numpy] Numpy operator diff #15906

Merged
merged 2 commits into from
Oct 30, 2019
Merged

[Numpy] Numpy operator diff #15906

merged 2 commits into from
Oct 30, 2019

Conversation

xiezhq-hermann
Copy link
Contributor

@xiezhq-hermann xiezhq-hermann commented Aug 15, 2019 •
edited
Loading

Description

Numpy compatible operator diff

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Numpy compatible operator diff added, including tests and docs

Comments

Thank you for your effort to review! @haojin2 @reminisce

@yzhliu yzhliu added the Numpy label Aug 16, 2019
@haojin2 haojin2 self-assigned this Sep 2, 2019
comaniac
comaniac suggested changes Sep 11, 2019
View reviewed changes
Copy link

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase to master and solve conflicts after resolving the comments.

python/mxnet/ndarray/numpy/_op.py Outdated Show resolved Hide resolved
python/mxnet/numpy/multiarray.py Outdated Show resolved Hide resolved
python/mxnet/symbol/numpy/_symbol.py Outdated Show resolved Hide resolved
python/mxnet/ndarray/numpy/_op.py Show resolved Hide resolved
python/mxnet/numpy/multiarray.py Show resolved Hide resolved
tests/python/unittest/test_numpy_op.py Show resolved Hide resolved
@xiezhq-hermann
numpy diff operator implemented
5d1f516 
append and prepend not supported yet

remove the prepend and append checking interface from the backend

refine the code, enrich the test set and all tests passed

registered the diff operator into npi scope

all tests passed

comments and minor modification

format codes and fix warning for sanity check

minor modification for sanity check

fix sanity

fix the tolerance bound of testing np.diff

resolve minor coding style issue

replace the given tests by random picking

minor fix
haojin2
haojin2 approved these changes Oct 30, 2019
View reviewed changes
Copy link
Contributor

@haojin2 haojin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haojin2 haojin2 merged commit 27bddf8 into apache:master Oct 30, 2019
haojin2 pushed a commit that referenced this pull request Oct 31, 2019
@vexilligera @haojin2
[Numpy] implement np.column_stack (#16594)
f9baec9 
* implement np.column_stack

* cpplint

* remove column_stack from numpy interoperability test temporarily

* style and test fix

* fix pylint and add interoperability test

* fix doc string, add comment, remove dead code

* pylint

* ci

* ci

* ci

* [Numpy] Numpy operator diff (#15906)

* numpy diff operator implemented

append and prepend not supported yet

remove the prepend and append checking interface from the backend

refine the code, enrich the test set and all tests passed

registered the diff operator into npi scope

all tests passed

comments and minor modification

format codes and fix warning for sanity check

minor modification for sanity check

fix sanity

fix the tolerance bound of testing np.diff

resolve minor coding style issue

replace the given tests by random picking

minor fix

* interoperability test added

* implement np.column_stack

* cpplint

* remove column_stack from numpy interoperability test temporarily

* style and test fix

* fix pylint and add interoperability test

* fix doc string, add comment, remove dead code

* pylint

* ci

* ci

* ci

* rebase resolve conflicts

* pylint
yajiedesign pushed a commit to yajiedesign/mxnet that referenced this pull request Nov 6, 2019
@xiezhq-hermann @yajiedesign
[Numpy] Numpy operator diff (apache#15906)
74aa217 
* numpy diff operator implemented

append and prepend not supported yet

remove the prepend and append checking interface from the backend

refine the code, enrich the test set and all tests passed

registered the diff operator into npi scope

all tests passed

comments and minor modification

format codes and fix warning for sanity check

minor modification for sanity check

fix sanity

fix the tolerance bound of testing np.diff

resolve minor coding style issue

replace the given tests by random picking

minor fix

* interoperability test added
yajiedesign pushed a commit to yajiedesign/mxnet that referenced this pull request Nov 6, 2019
@vexilligera @yajiedesign
[Numpy] implement np.column_stack (apache#16594)
b410fdf 
* implement np.column_stack

* cpplint

* remove column_stack from numpy interoperability test temporarily

* style and test fix

* fix pylint and add interoperability test

* fix doc string, add comment, remove dead code

* pylint

* ci

* ci

* ci

* [Numpy] Numpy operator diff (apache#15906)

* numpy diff operator implemented

append and prepend not supported yet

remove the prepend and append checking interface from the backend

refine the code, enrich the test set and all tests passed

registered the diff operator into npi scope

all tests passed

comments and minor modification

format codes and fix warning for sanity check

minor modification for sanity check

fix sanity

fix the tolerance bound of testing np.diff

resolve minor coding style issue

replace the given tests by random picking

minor fix

* interoperability test added

* implement np.column_stack

* cpplint

* remove column_stack from numpy interoperability test temporarily

* style and test fix

* fix pylint and add interoperability test

* fix doc string, add comment, remove dead code

* pylint

* ci

* ci

* ci

* rebase resolve conflicts

* pylint
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@comaniac comaniac comaniac requested changes

@haojin2 haojin2 haojin2 approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees

@haojin2 haojin2

Labels
Numpy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xiezhq-hermann @comaniac @haojin2 @yzhliu