Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix Nightly Tests for Binaries #16451

Merged
merged 4 commits into from
Oct 14, 2019
Merged

Fix Nightly Tests for Binaries #16451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
63a34cb
copy missing requirements file
mseth10 Oct 11, 2019
5059177
not treating numpy warnings as errors
mseth10 Oct 11, 2019
02433c5
updating six package version
mseth10 Oct 11, 2019
f38bee4
Revert "updating six package version"
mseth10 Oct 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ci/docker/Dockerfile.build.ubuntu_nightly_gpu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ COPY install/deb_ubuntu_ccache.sh /work/
RUN /work/deb_ubuntu_ccache.sh

COPY install/ubuntu_python.sh /work/
COPY install/requirements /work/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so the test environment is in the '/work/` directory?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, work directory is created inside the docker and all required files are copied there.

RUN /work/ubuntu_python.sh

COPY install/ubuntu_scala.sh /work/
Expand Down
2 changes: 1 addition & 1 deletion tests/utils/notebook_test/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def run_notebook(notebook, notebook_dir, kernel=None, no_cache=False, temp_dir='
nbformat.write(notebook, output_file)
output_nb = io.open(output_file, mode='r', encoding='utf-8')
for line in output_nb:
if "Warning:" in line:
if "Warning:" in line and "numpy operator signatures" not in line:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reminisce

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The warning message of numpy operator signature is for python version < 3.5. It does not affect functionality, but merely used for building numpy op documentation. I'm fine with this change.

errors.append("Warning:\n" + line)
if len(errors) > 0:
logging.error('\n'.join(errors))
Expand Down