This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Fix Nightly Tests for Binaries #16451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 02433c5.
mseth10
force-pushed
the
debug_nightly
branch
from
e5c17cd
to
f38bee4
Compare
marcoabreu
reviewed
Oct 12, 2019
| @@ -111,7 +111,7 @@ def run_notebook(notebook, notebook_dir, kernel=None, no_cache=False, temp_dir=' | |||
| nbformat.write(notebook, output_file) | |||
| output_nb = io.open(output_file, mode='r', encoding='utf-8') | |||
| for line in output_nb: | |||
| if "Warning:" in line: | |||
| if "Warning:" in line and "numpy operator signatures" not in line: | |||
There was a problem hiding this comment.
The warning message of numpy operator signature is for python version < 3.5. It does not affect functionality, but merely used for building numpy op documentation. I'm fine with this change.
|
@ThomasDelteil @larroy ping for review |
ThomasDelteil
approved these changes
Oct 12, 2019
|
@marcoabreu can you please review and merge. Thanks. |
samskalicky
approved these changes
Oct 14, 2019
ChaiBapchya
reviewed
Oct 14, 2019
| @@ -29,6 +29,7 @@ COPY install/deb_ubuntu_ccache.sh /work/ | |||
| RUN /work/deb_ubuntu_ccache.sh | |||
|
|
|||
| COPY install/ubuntu_python.sh /work/ | |||
| COPY install/requirements /work/ | |||
There was a problem hiding this comment.
so the test environment is in the '/work/` directory?
There was a problem hiding this comment.
yes, work directory is created inside the docker and all required files are copied there.
aaronmarkham
pushed a commit
to aaronmarkham/incubator-mxnet
that referenced
this pull request
Oct 16, 2019
* copy missing requirements file * not treating numpy warnings as errors * updating six package version * Revert "updating six package version" This reverts commit 02433c5.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes nightly tests for binaries, that have been failing since 09/19.
One of the errors is because requirements file was not copied to the teat environment.
The other errors are due to numpy warnings treated as errors.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments