Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Aggregated zero grad #16446

Merged
merged 11 commits into from
Oct 15, 2019
Merged

Aggregated zero grad #16446

merged 11 commits into from
Oct 15, 2019

Conversation

drivanov
Copy link
Contributor

Description

New MxNet operator for zeroing of multiple arrays.

Checklist

Essentials

  • Changes are complete
  • All changes have test coverage:
  • Code is well-documented:
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Previously existed test_zero_grad() is extended for different dtypes. Besides, now it uses a newly implemented mx.nd.reset_arrays operator and also contains test for zeroing of multiple arrays of different shapes.

@drivanov drivanov requested a review from szha as a code owner October 11, 2019 20:08
Copy link
Member

@ptrendx ptrendx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ptrendx ptrendx merged commit 67e1e68 into apache:master Oct 15, 2019
aaronmarkham pushed a commit to aaronmarkham/incubator-mxnet that referenced this pull request Oct 16, 2019
* Trigger CI

* Aggregated zeroing of the gradients/arrays

* New files for aggregated zeroing of the gradients/arrays

* Adding possibility to reset the arrays of different types.

* Minor cleanup
@drivanov drivanov deleted the aggregated_zero_grad branch October 16, 2019 23:18
apeforest pushed a commit that referenced this pull request Nov 6, 2019
* Trigger CI

* Aggregated zeroing of the gradients/arrays

* New files for aggregated zeroing of the gradients/arrays

* Adding possibility to reset the arrays of different types.

* Minor cleanup
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants