This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Julia: add API docs back #16348
Merged
Julia: add API docs back #16348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iblislin
approved these changes
Oct 1, 2019
|
ah, please modify your commit message and make sure not pinging someone. |
|
Updated. Moreover, @iblis17, is it fine to merge the commit onto your 1.5.x branch? |
|
yeah, I will backport it in another PR. |
`ndarray` and `symbolic-node` have been refactored by splitting into a few files in commits ed83071 and 36a3cb8, but the corresponding document setting for MXNet.jl is not updated yet. List all split source files into the `at_autodoc` setting. Also refer to the `at_autodoc` setting in `julia/docs/src/api/optimizer.md`
|
I think the CI failures are unrelated. |
|
Just found that this PR isn't merged into master. |
iblislin
added a commit
that referenced
this pull request
Dec 17, 2019
* julia: bump window prebult binary version to v1.5.0 (#15608) - remove file REQUIRE, it's stale for Pkg3.jl * update julia install doc (#15609) * julia: fix `mx.forward` kwargs checking (#16138) close dmlc/MXNet.jl#431 * Julia: add API docs back (#16348) `ndarray` and `symbolic-node` have been refactored by splitting into a few files in commits ed83071 and 36a3cb8, but the corresponding document setting for MXNet.jl is not updated yet. List all split source files into the `at_autodoc` setting. Also refer to the `at_autodoc` setting in `julia/docs/src/api/optimizer.md`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ndarrayandsymbolic-nodehave been refactored by splitting into afew files in commits ed83071 and 36a3cb8, but the corresponding
document setting for MXNet.jl is not updated yet.
List all split source files into the
at_autodocsetting.Also refer to the
at_autodocsetting injulia/docs/src/api/optimizer.mdChecklist
Essentials
Changes
Comments
ndarrayandsymbolic-nodearticles to sectionsas
optimizerarticle?