Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

backport Julia patches to v1.5.x #16142

Merged
merged 4 commits into from
Dec 17, 2019
Merged

backport Julia patches to v1.5.x #16142

merged 4 commits into from
Dec 17, 2019

Conversation

iblislin
Copy link
Member

@iblislin iblislin commented Sep 11, 2019 •
edited
Loading

@iblislin iblislin requested a review from szha as a code owner September 11, 2019 09:35
@iblislin
Copy link
Member Author

cc @TaoLv

@apeforest apeforest closed this Sep 17, 2019
@iblislin
Copy link
Member Author

Hi @apeforest , could you elaborate the reason of closing this PR?

@iblislin iblislin mentioned this pull request Sep 22, 2019
Closed
@apeforest apeforest reopened this Sep 28, 2019
@apeforest
Copy link
Contributor

Hi @iblis17 I am so sorry. This must be an accident when I was viewing PRs on my cell phone. I have re-opened it for review. Again, I am truly sorry for the inconvenience caused by my misoperation.

@iblislin
Copy link
Member Author

haha, 👌

@apua @iblislin
Julia: add API docs back (#16348)
f3b4377 
`ndarray` and `symbolic-node` have been refactored by splitting into a
few files in commits ed83071 and 36a3cb8, but the corresponding
document setting for MXNet.jl is not updated yet.

List all split source files into the `at_autodoc` setting.

Also refer to the `at_autodoc` setting in `julia/docs/src/api/optimizer.md`
@iblislin iblislin added the Julia label Oct 2, 2019
@iblislin iblislin merged commit 3f449aa into v1.5.x Dec 17, 2019
@iblislin iblislin deleted the ib/backport-jl branch December 17, 2019 12:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
Julia
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iblislin @apeforest @Ksoy @apua