This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
adding redirects so that old website API links surfaced from searches #16342
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
945f9b8
adding redirects so that old website API links surfaced from searches…
sojiadeshina 84bd84e
add redirects for links in top level nav bar of old webpage
sojiadeshina 13c1594
Update .htaccess
marcoabreu 50557a8
adding redirects so that old website API links surfaced from searches…
sojiadeshina a129993
Merge branch 'master' into website-link-fixes
aaronmarkham 7ecd76e
updating based on available features
aaronmarkham 9dc366f
nudge CI
ThomasDelteil File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you elaborate? I think we prefer running a 404 page rather than displaying the directory index
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aaronmarkham did you test that 404 are still respected and we don't display the index when you removed that line?
@marcoabreu my understanding is that this no indexing would have been set at the virtual host level in the apache config already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed that because infra said it wasn't supported and it was breaking on staging.
https://issues.apache.org/jira/browse/INFRA-19187
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once I removed that line this code would work on staging... with it, the code would result in a 500 error. I didn't test variations, but if you review the link and the docs link that they refer to for supported features, maybe you can turn on something else that will give you the desired effect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see, they restricted the usage to a certain set of commands. Fine to go ahead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
http://mxnet.incubator.apache.org/api/perl/docs/tutorials/ the option is available on prod, we need to ask Apache infra to align beta / prod configs