Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

adding redirects so that old website API links surfaced from searches #16342

Merged
merged 7 commits into from
Oct 2, 2019

Conversation

ThomasDelteil
Copy link
Contributor

Reopened from @sad- PR

@@ -1,4 +1,3 @@
Options -Indexes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you elaborate? I think we prefer running a 404 page rather than displaying the directory index

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaronmarkham did you test that 404 are still respected and we don't display the index when you removed that line?
@marcoabreu my understanding is that this no indexing would have been set at the virtual host level in the apache config already.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed that because infra said it wasn't supported and it was breaking on staging.
https://issues.apache.org/jira/browse/INFRA-19187

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once I removed that line this code would work on staging... with it, the code would result in a 500 error. I didn't test variations, but if you review the link and the docs link that they refer to for supported features, maybe you can turn on something else that will give you the desired effect.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, they restricted the usage to a certain set of commands. Fine to go ahead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http://mxnet.incubator.apache.org/api/perl/docs/tutorials/ the option is available on prod, we need to ask Apache infra to align beta / prod configs

@aaronmarkham
Copy link
Contributor

This was already approved on soji's PR, so I'm merging now.

@aaronmarkham aaronmarkham merged commit 6931748 into apache:master Oct 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants