Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

add mkl installation temp fix #16304

Merged
merged 1 commit into from
Sep 27, 2019
Merged

add mkl installation temp fix #16304

merged 1 commit into from
Sep 27, 2019

Conversation

lanking520
Copy link
Member

@lanking520 lanking520 commented Sep 27, 2019

Description

Currently, our CI is down due to the Intel library GPG key expiration issue. This fix is planned to temporarily bypass the certificate check. The right fix should be the GPG key update on Intel side. Please revert this change when that happened. @PatricZhao

#16300

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@lanking520
Copy link
Member Author

@aaronmarkham @apeforest

Copy link
Contributor

@apeforest apeforest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@marcoabreu marcoabreu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you gonna track that this gets reverted qing?

@lanking520
Copy link
Member Author

Are you gonna track that this gets reverted qing?

yes

@lanking520 lanking520 merged commit 943bed5 into apache:master Sep 27, 2019
larroy pushed a commit to larroy/mxnet that referenced this pull request Sep 28, 2019
sojiadeshina pushed a commit to sojiadeshina/incubator-mxnet that referenced this pull request Sep 30, 2019
lanking520 added a commit that referenced this pull request Oct 3, 2019
lanking520 added a commit to lanking520/incubator-mxnet that referenced this pull request Oct 4, 2019
lanking520 added a commit that referenced this pull request Oct 10, 2019
lanking520 added a commit that referenced this pull request Oct 11, 2019
marcoabreu pushed a commit that referenced this pull request Oct 11, 2019
aaronmarkham pushed a commit to aaronmarkham/incubator-mxnet that referenced this pull request Oct 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants